Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform-iam: profile a workstation for the archeologists #296

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Oct 27, 2023

No description provided.

@delroth
Copy link
Contributor

delroth commented Oct 28, 2023

How do you envision the terraform vs. terraform-iam separation? I thought terraform-iam should just be for the extra-privileged stuff, but "the configuration of the archeologists workstation" doesn't seem like such a thing.

Is this temporary and meant to be split off at some point? If so, could it be documented as such? If not, I don't understand the boundaries of the split :)

@zimbatm
Copy link
Member Author

zimbatm commented Oct 28, 2023

You and me both :)

I had limited time to unblock the archeologist team so I hacked this together. The terraform-iam/fastlylogs also has a S3 bucket in there.

I feel like this is not the right line to split a module. It would be nice if you could read the IAM roles so at least you could run a plan without it failing in the noop case. Then we could merge those back again. And maybe split the root modules on different lines, like based on the project.

@zimbatm zimbatm merged commit 1b97b02 into master Oct 29, 2023
2 checks passed
@zimbatm zimbatm deleted the archeologist-ec2-instance branch October 29, 2023 17:30
@zimbatm
Copy link
Member Author

zimbatm commented Oct 29, 2023

I'll get that cleaned later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants