ocamlPackages.opam-file-format: 2.0.0 -> 2.1.2 #106107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build opaline ocamlPackages.opam-format ocamlPackages.opam-repository dune-release |
vbgl
reviewed
Dec 7, 2020
sternenseemann
force-pushed
the
opam-file-format-2.1.1
branch
from
39735bc to
c4dc18b
Compare
|
I've rebased the commits to prevent the broken state you pointed out and also switched to |
|
I guess this will be much easier to review after #106150 has been merged. |
|
The |
|
Might be worth to wait for the next release which should come shortly: ocaml/opam-file-format#36 (comment) Upstream is now going a different direction with the fix than my fix in this package: ocaml/opam-file-format#37 |
|
Sounds good. Thanks. |
sternenseemann
force-pushed
the
opam-file-format-2.1.1
branch
from
c4dc18b to
af0f9ce
Compare
sternenseemann
changed the title
|
Okay unfortunately 2.1.2 did not fix the issue, I'll see what I can find out. |
sternenseemann
force-pushed
the
opam-file-format-2.1.1
branch
from
af0f9ce to
df0aaa1
Compare
|
Updated to 2.1.2 and applied the relevant change from ocaml/opam-file-format#41 as a patch. |
|
@ofborg build opaline |
|
@ofborg eval |
Result of 6 packages failed to build:
549 packages built:
|
sternenseemann
force-pushed
the
opam-file-format-2.1.1
branch
from
df0aaa1 to
6396d02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixed Version of #102671
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)