Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.requests-cache: 0.6.4 -> 0.7.0 #129635

Merged
merged 2 commits into from
Jul 9, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jul 8, 2021

Motivation for this change

Update to latest upstream release 0.7.0

Change log: https://github.com/reclosedev/requests-cache/blob/master/HISTORY.md#070-2021-07-07

tvbd_api doesn't support requests-cache > 0.6.0 (dbr/tvdb_api#94) yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Jul 8, 2021

Result of nixpkgs-review pr 129635 run on x86_64-linux 1

3 packages marked as broken and skipped:
  • python38Packages.tvdb_api
  • python39Packages.tvdb_api
  • tvnamer
5 packages built:
  • cryptop
  • python38Packages.pysychonaut
  • python38Packages.requests-cache
  • python39Packages.pysychonaut
  • python39Packages.requests-cache

@r-rmcgibbo
Copy link

r-rmcgibbo commented Jul 8, 2021

Result of nixpkgs-review pr 129635 at 8692bf9 run on aarch64-linux 1

2 packages failed to build:
6 packages built successfully:
  • cryptop
  • python38Packages.pysychonaut
  • python38Packages.requests-cache
  • python39Packages.pysychonaut
  • python39Packages.requests-cache
  • tvnamer
1 suggestion:
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/tvdb_api/default.nix:25:0:

       |
    25 |     description = "Simple to use TVDB (thetvdb.com) API in Python";
       | ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.


Result of nixpkgs-review pr 129635 at 8692bf9 run on x86_64-linux 1

2 packages failed to build:
6 packages built successfully:
  • cryptop
  • python38Packages.pysychonaut
  • python38Packages.requests-cache
  • python39Packages.pysychonaut
  • python39Packages.requests-cache
  • tvnamer
1 suggestion:
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/tvdb_api/default.nix:25:0:

       |
    25 |     description = "Simple to use TVDB (thetvdb.com) API in Python";
       | ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@peterhoeg
Copy link
Member

tvnamer is the only thing in nixpkgs that uses tvdb_api and that was specifically handled in #128848 so those failures are fine.

@SuperSandro2000 SuperSandro2000 merged commit 3c5f5c1 into NixOS:master Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants