Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openethereum: mark as broken #140762

Closed
wants to merge 1 commit into from
Closed

Conversation

yvan-sraka
Copy link
Contributor

Motivation for this change

When I try to nix-shell -p openethereum on my 21.11pre320334.82155ff501c (Porcupine), I got the cargo build error:

error[E0061]: this function takes 1 argument but 2 arguments were supplied
    --> /build/openethereum-3.2.6-vendor.tar.gz/logos-derive/src/lib.rs:55:20
     |
55   |             extras.insert(util::ident(&ext), |_| panic!("Only one #[extras] attribute can be declared."));
     |                    ^^^^^^ -----------------  ----------------------------------------------------------- supplied 2 arguments
     |                    |
     |                    expected 1 argument
     |
note: associated function defined here

error[E0061]: this function takes 1 argument but 2 arguments were supplied
    --> /build/openethereum-3.2.6-vendor.tar.gz/logos-derive/src/lib.rs:89:23
     |
89   |                 error.insert(variant, |_| panic!("Only one #[error] variant can be declared."));
     |                       ^^^^^^ -------  -------------------------------------------------------- supplied 2 arguments
     |                       |
     |                       expected 1 argument
     |
note: associated function defined here

error[E0061]: this function takes 1 argument but 2 arguments were supplied
    --> /build/openethereum-3.2.6-vendor.tar.gz/logos-derive/src/lib.rs:93:21
     |
93   |                 end.insert(variant, |_| panic!("Only one #[end] variant can be declared."));
     |                     ^^^^^^ -------  ------------------------------------------------------ supplied 2 arguments
     |                     |
     |                     expected 1 argument
     |
note: associated function defined here
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 6, 2021
@bachp
Copy link
Member

bachp commented Nov 20, 2021

Even the recently released v3.3.0 doesn't work with Rust 1.53. I don't see this to be fixed upstream anytime soon. So I think it is OK to mark this as broken.

See paritytech/lunarity#12 and openethereum/openethereum#547

@netthier
Copy link
Contributor

netthier commented Feb 3, 2022

The fix has been merged into master about two weeks ago but I don't think there has been a stable release including it yet.
Merged PR: openethereum/openethereum#463

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 13, 2022
@wegank wegank closed this Dec 23, 2022
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants