Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "google-compute-engine: 20190124 -> 20200113.0 (#131761)" #148467

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Revert "google-compute-engine: 20190124 -> 20200113.0 (#131761)" #148467

merged 1 commit into from
Dec 6, 2021
+26 −67

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Dec 3, 2021

Motivation for this change

This reverts commit 1748291.

This upgrade broke the google-compute-config module. See #144761 for more info.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@talyz
Revert "google-compute-engine: 20190124 -> 20200113.0 (NixOS#131761)"
5a4ea49 
This reverts commit 1748291.

This upgrade broke the google-compute-config module. See
NixOS#144761 for more info.
@talyz talyz requested review from cpcloud, flokli and picnoir December 3, 2021 16:36
@ofborg ofborg bot requested a review from zimbatm December 3, 2021 17:06
flokli
flokli approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really test this right now, but looks good for me.

@talyz talyz merged commit f9dc630 into NixOS:master Dec 6, 2021
@talyz talyz deleted the revert-gce-upgrade branch December 6, 2021 08:51
@github-actions github-actions bot mentioned this pull request Dec 6, 2021
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

Successfully created backport PR #148936 for release-21.11.

@picnoir picnoir mentioned this pull request Feb 11, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

@flokli flokli flokli approved these changes

@picnoir picnoir Awaiting requested review from picnoir

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@talyz @flokli @cpcloud