libnitrokey: init at 3.8

[panicgh]

Description of changes

Package libnitrokey separately and use it in nitrokey-app instead of using the bundled libnitrokey (via git submodule). I made @KaiHa maintainer of it. I hope this is ok.

There is also an internal dependency "cppcodec" and I made @KaiHa maintainer of it (same as for nitrokey-app). I hope this is ok. I use release v0.2 of cppcodec instead of the very old submodule commit from upstream. I created an upstream issue to ask if they might do the same.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[RaitoBezarius]

Did @KaiHa consent to be maintainer?

[panicgh]

No, I hope to get the feedback in this PR (draft). It was primarily a choice caused by the splitting off of libnitrokey, which KaiHa already maintains indirectly as bundled part of nitrokey-app.
I also consider adding myself to the maintainers, as I intend to use a relatively new Nitrokey 3 in the near future and probably need to follow the upstream more closely for updates.
But for the moment I wait for #221656 because it can also use the standalone libnitrokey (e.g. adding support for Nitrokey Pro to nitropy) and I'll propose to add it once it is possible (it has to be added to the nitropy wrapper as it is not a build dependency; I already have a patch locally).

[RaitoBezarius]

No, I hope to get the feedback in this PR (draft). It was primarily a choice caused by the splitting off of libnitrokey, which KaiHa already maintains indirectly as bundled part of nitrokey-app. I also consider adding myself to the maintainers, as I intend to use a relatively new Nitrokey 3 in the near future and probably need to follow the upstream more closely for updates. But for the moment I wait for #221656 because it can also use the standalone libnitrokey (e.g. adding support for Nitrokey Pro to nitropy) and I'll propose to add it once it is possible (it has to be added to the nitropy wrapper as it is not a build dependency; I already have a patch locally).

Please don't add a maintainer to a list without consent first, even if it sounds like a good idea. Better: let the maintainer add themselves in a future PR if that's needed at all.

[KaiHa]

No, I hope to get the feedback in this PR (draft). It was primarily a choice caused by the splitting off of libnitrokey, which KaiHa already maintains indirectly as bundled part of nitrokey-app. I also consider adding myself to the maintainers, as I intend to use a relatively new Nitrokey 3 in the near future and probably need to follow the upstream more closely for updates. But for the moment I wait for #221656 because it can also use the standalone libnitrokey (e.g. adding support for Nitrokey Pro to nitropy) and I'll propose to add it once it is possible (it has to be added to the nitropy wrapper as it is not a build dependency; I already have a patch locally).

Hi, I must admit that for some time now I do not live up to my role as the maintainer of nitrokey-app in NixOS. And I was kind of surprised that I am now listed as the only maintainer. I am no longer a user of the nitrokey-app, because all the stuff I use my Nitrokey for is possible without the app. To cut a long story short, please don't make me a maintainer of libnitroykey :) And if anyone is interested in taking over maintainership of the nitrokey-app, please feel free.

Regarding your change in general @panicgh, it makes sense please proceed.

[RaitoBezarius]

Please add me as a maintainer of nitrokey stuff for now, as I am using Nitrokey actively.

[frogamic]

@RaitoBezarius would you like to open a PR to be added as a maintainer of pynitrokey too? Although I am maintainer and try to keep it updated I do not actually use a nitrokey as I bricked my nitrokey start and my nitrokey 3 is on backorder

[RaitoBezarius]

I will do so :) Le lun. 27 mars 2023 à 00:52, Dominic Shelton ***@***.***> a écrit :

…

@RaitoBezarius <https://github.com/RaitoBezarius> would you like to open a PR to be added as a maintainer of pynitrokey too? Although I am maintainer and try to keep it updated I do not actually use a nitrokey as I bricked my nitrokey start and my nitrokey 3 is on backorder — Reply to this email directly, view it on GitHub <#223242 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACMZRHM36BO4I7GD7LYGZTW6DCB3ANCNFSM6AAAAAAWIFURV4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[panicgh]

Thanks @KaiHa for the clarification, I removed you as maintainer from the new pkgs. Thanks @RaitoBezarius for volunteering as maintainer. I set the two of us as maintainers of the new pkgs. I decided to mark this PR as ready for review. If it gets merged before #221656, we can suggest there to include libnitrokey in nitropy or we create a new PR for it.

[RaitoBezarius]

Please move cppcodec to the top-level so that everyone can depend on it. Other than this, LGTM. Tested nitrokey-app (not on real HW yet).

[RaitoBezarius]

LGTM

[panicgh]

@RaitoBezarius Should I add you as maintainer of nitrokey-app?

[panicgh]

@ofborg eval

[RaitoBezarius]

@RaitoBezarius Should I add you as maintainer of nitrokey-app?

I am planning to use less of this, so I will be a "not super active maintainer" of nitrokey-app, my Nitrokey stuff does not support it yet.