Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hmm: replace rustc-serialize version to unbreak build #310673

Merged
merged 1 commit into from
May 11, 2024
Merged

hmm: replace rustc-serialize version to unbreak build #310673

merged 1 commit into from
May 11, 2024

Conversation

kiike
Copy link
Member

@kiike kiike commented May 10, 2024 •
edited
Loading

Description of changes

This PR adopts the same patch offered in #310125 to unbreak the build with versions of Rust > 1.76. Part of ZHF: #309482

Things done

  • Add patch

  • Built on platform(s)

    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

    • sandbox = relaxed
    • sandbox = true

  • Tested, as applicable:

  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage

  • Tested basic functionality of all binary files (usually in ./result/bin/)

  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module

  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@kiike kiike added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 10, 2024
@kiike kiike requested a review from figsoda May 10, 2024 20:46
pluiedev
pluiedev approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@pluiedev pluiedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 310673 run on x86_64-linux 1

1 package built:
  • hmm

@wegank wegank merged commit 4e9d164 into NixOS:master May 11, 2024
29 of 31 checks passed
@kiike kiike deleted the zhf/hmm branch May 11, 2024 14:52
@pluiedev pluiedev mentioned this pull request May 13, 2024
Merged
13 tasks
pluiedev added a commit to pluiedev/nixpkgs that referenced this pull request May 13, 2024
@pluiedev
cargo-raze: 0.16.0 -> 0.16.1, unbreak, modernize
059f2de 
Contains the same fix as in NixOS#310673 and NixOS#310125 that allows it to build
on Rust >1.76. However, I think this patch might have to be a permanent
one as upstream has been abandoned and unmaintained.

Also removed some spurious `with lib;` and `rec` use, moved to use
`pkgs/by-name` and reformatted using `nixfmt-rfc-style`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pluiedev pluiedev pluiedev approved these changes

@figsoda figsoda Awaiting requested review from figsoda

Assignees
No one assigned
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiike @pluiedev @wegank