-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ntpd-rs: migrate to by-name & add updateScript, 1.2.0 -> 1.2.2 #327441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lassulus
approved these changes
Jul 15, 2024
getchoo
added
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Jul 15, 2024
NotAShelf
approved these changes
Jul 15, 2024
getchoo
added
the
12.approvals: 2
This PR was reviewed and approved by two reputable people
label
Jul 15, 2024
ofborg
bot
added
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 0
This PR does not cause any packages to rebuild on Linux
labels
Jul 15, 2024
seems like a build-failure?
|
wegank
removed
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Jul 16, 2024
Sigh, I hate this testsuite. Builds fine locally. |
fpletz
approved these changes
Jul 20, 2024
fpletz
changed the title
ntpd-rs: migrate to by-name & add updateScript
ntpd-rs: migrate to by-name & add updateScript, 1.2.0 -> 1.2.2
Jul 20, 2024
ofborg
bot
added
10.rebuild-linux: 1-10
10.rebuild-linux: 1
and removed
10.rebuild-linux: 0
This PR does not cause any packages to rebuild on Linux
labels
Jul 20, 2024
getchoo
added
12.approvals: 1
This PR was reviewed and approved by one reputable person
12.approved-by: package-maintainer
This PR was reviewed and approved by a maintainer listed in the package
and removed
12.approvals: 2
This PR was reviewed and approved by two reputable people
labels
Jul 20, 2024
fpletz
force-pushed
the
pkgs/ntpd-rs/by-name
branch
from
July 20, 2024 02:05
eefe60a
to
a2c636f
Compare
After having disabled the failing tests now new tests failed on ofborg. Disabling testsuite. We always had some flaky tests in ntpd-rs. Upstream needs to fix this before we can enable it again. |
fpletz
force-pushed
the
pkgs/ntpd-rs/by-name
branch
from
July 20, 2024 02:08
a2c636f
to
f2a6b12
Compare
Reported upstream: pendulum-project/ntpd-rs#1396 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
12.approvals: 1
This PR was reviewed and approved by one reputable person
12.approved-by: package-maintainer
This PR was reviewed and approved by a maintainer listed in the package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Mainly for @NixOS/nixpkgs-merge-bot
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.