Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntpd-rs: migrate to by-name & add updateScript, 1.2.0 -> 1.2.2 #327441

Merged
merged 5 commits into from
Jul 20, 2024

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Jul 15, 2024

Description of changes

Mainly for @NixOS/nixpkgs-merge-bot

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 15, 2024
@getchoo getchoo added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jul 15, 2024
@ofborg ofborg bot requested a review from fpletz July 15, 2024 20:03
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 15, 2024
@Lassulus
Copy link
Member

seems like a build-failure?

failures:
---- daemon::ntp_source::tests::test_deny_stops_poll stdout ----
thread 'daemon::ntp_source::tests::test_deny_stops_poll' panicked at ntpd/src/daemon/ntp_source.rs:739:9:
assertion failed: timestamp.is_some()
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
---- daemon::ntp_source::tests::test_timeroundtrip stdout ----
thread 'daemon::ntp_source::tests::test_timeroundtrip' panicked at ntpd/src/daemon/ntp_source.rs:698:35:
called `Option::unwrap()` on a `None` value
failures:
    daemon::ntp_source::tests::test_deny_stops_poll
    daemon::ntp_source::tests::test_timeroundtrip

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 16, 2024
@fpletz
Copy link
Member

fpletz commented Jul 20, 2024

Sigh, I hate this testsuite. Builds fine locally.

@fpletz fpletz changed the title ntpd-rs: migrate to by-name & add updateScript ntpd-rs: migrate to by-name & add updateScript, 1.2.0 -> 1.2.2 Jul 20, 2024
@ofborg ofborg bot requested a review from fpletz July 20, 2024 01:42
@ofborg ofborg bot added 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 20, 2024
@getchoo getchoo added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package and removed 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Jul 20, 2024
@fpletz fpletz force-pushed the pkgs/ntpd-rs/by-name branch from eefe60a to a2c636f Compare July 20, 2024 02:05
@fpletz
Copy link
Member

fpletz commented Jul 20, 2024

After having disabled the failing tests now new tests failed on ofborg. Disabling testsuite. We always had some flaky tests in ntpd-rs. Upstream needs to fix this before we can enable it again.

@fpletz fpletz force-pushed the pkgs/ntpd-rs/by-name branch from a2c636f to f2a6b12 Compare July 20, 2024 02:08
@fpletz
Copy link
Member

fpletz commented Jul 20, 2024

Reported upstream: pendulum-project/ntpd-rs#1396

@Lassulus Lassulus merged commit eb1a2f0 into NixOS:master Jul 20, 2024
24 of 26 checks passed
@getchoo getchoo deleted the pkgs/ntpd-rs/by-name branch July 20, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants