Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

viddy: 0.4.0 -> 1.0.1 #336100

Merged
merged 2 commits into from
Aug 25, 2024
Merged

viddy: 0.4.0 -> 1.0.1 #336100

merged 2 commits into from
Aug 25, 2024

Conversation

phanirithvij
Copy link
Member

@phanirithvij phanirithvij commented Aug 20, 2024 •
edited
Loading

Description of changes

viddy has moved from rust to go, sachaos/viddy#117
v1.0.0 planned in few days sachaos/viddy#117 (comment)
v1.0.0 released 2024-08-22

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage 
    1 package built:
viddy
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc @j-hui

Add a 👍 reaction to pull requests you find important.

@phanirithvij phanirithvij force-pushed the viddy-rust-rewrite branch 2 times, most recently from de3c81b to e5f7c33 Compare August 22, 2024 03:02
@sachaos sachaos mentioned this pull request Aug 22, 2024
Open
10 tasks
@phanirithvij phanirithvij changed the title [WIP] viddy: 0.4.0 -> 1.0.0 viddy: 0.4.0 -> 1.0.0 Aug 22, 2024
@phanirithvij phanirithvij marked this pull request as ready for review August 22, 2024 06:24
phanirithvij and others added 2 commits August 25, 2024 01:03
@phanirithvij @fpletz
viddy: add phanirithvij as maintainer
6f525d9 
Signed-off-by: phanirithvij <[email protected]>
@phanirithvij @SuperSandro2000 @fpletz
viddy: 0.4.0 -> 1.0.1
42e323c 
Signed-off-by: phanirithvij <[email protected]>
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Franz Pletz <[email protected]>
@fpletz fpletz force-pushed the viddy-rust-rewrite branch from 06b1be5 to 42e323c Compare August 24, 2024 23:04
@fpletz fpletz changed the title viddy: 0.4.0 -> 1.0.0 viddy: 0.4.0 -> 1.0.1 Aug 24, 2024
@SuperSandro2000 SuperSandro2000 merged commit c0d40cb into NixOS:master Aug 25, 2024
27 of 29 checks passed
@phanirithvij phanirithvij deleted the viddy-rust-rewrite branch August 26, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eljamm eljamm eljamm left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phanirithvij @SuperSandro2000 @eljamm