-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ffmpeg_7: 7.0.2 -> 7.1; xeve: 0.5.0 -> 0.5.1 #346552
Conversation
Closes: NixOS#322990
196b8a9
to
7ad7e69
Compare
@Atemu @jopejoe1 Any objections to just merging this? It looks like, in classic FFmpeg fashion, they’ve broken at least one API, but I expect it to be less bad than 6 → 7 which has gone smoothly so far, and it’d be nice to ship 24.11 on the latest release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff LGTM.
The changelog looks small enough and odd API breakages like that one can only really be found by pushing this to unstable.
I'd like to see the patch upstreamed though.
Result of 7 packages built:
|
The FFmpeg site is down right now. I’ll put myself through finally learning |
Patch sent upstream as https://patchwork.ffmpeg.org/project/ffmpeg/patch/[email protected]/. |
I’ll look into upstreaming the tests fix some other time.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.