-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
daggerfall-unity: init at 1.1.1 #350177
base: master
Are you sure you want to change the base?
daggerfall-unity: init at 1.1.1 #350177
Conversation
9a04837
to
f01a5fb
Compare
f01a5fb
to
9560322
Compare
9560322
to
42f5cb9
Compare
b3f7cc7
to
1843251
Compare
c0ec73a
to
b0da7b3
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nix-update-script-version-regex-mismatch/55578/1 |
runHook postInstall | ||
''; | ||
|
||
appendRunpaths = map (pkg: "${lib.getLib pkg}/lib") (finalAttrs.buildInputs); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use lib.makeLibraryPath here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might work tho the script expects an array of paths not a colon separated string
b4239ba
to
201391a
Compare
Includes the manual for Daggerfall Unity. daggerfall-unity-unfree also includes the manual for Daggerfall itself. Closes NixOS#109385. Co-authored-by: Sandro <[email protected]>
201391a
to
bc4680c
Compare
I could not figure out how to build this from source. The upstream build docs only explain how to do it from the Unity GUI, and there is no
.csproj
or.sln
file in the project to use withbuildDotnetModule
or the like.Closes #109385.
Tested:
./result/DaggerfallUnity.x86_64
starts the GUI and asks for the Daggerfall game files.nix-shell maintainers/scripts/update.nix --argstr package daggerfall-unity
breaks badly. Diff:Output:
No idea what's going on there.
Remaining issues:
strings ./result/UnityPlayer.so | grep '\.so'
listed two libraries I could not find, but which did not seem to be necessary, at least for basic functionality:libGLES_CM.so.1
, andlibmono.so
. Please add a comment if you know where to find them, or why they would not be necessary.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.