Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postgresql: Fix passthru when using postgresqlWithPackages #351967

Closed
wants to merge 5,994 commits into from
Closed

Postgresql: Fix passthru when using postgresqlWithPackages #351967

wants to merge 5,994 commits into from

Conversation

m1-s
Copy link
Contributor

@m1-s m1-s commented Oct 28, 2024

Currently, when using postgresqlWithPackages the passthru attributes are lost. This is causing errors in the postgresql nixos module as it needs the withJit passthru attributes.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

r-ryantm and others added 30 commits October 14, 2024 01:37
@r-ryantm @github-actions
easyrsa: 3.2.0 -> 3.2.1
040a372 
(cherry picked from commit 5821bf9)
@markuskowa
[24.05] panoply: 5.4.1 -> 5.5.3 (NixOS#348069)
0a015d5
@tomodachi94 @github-actions
python3Packages.django-mdeditor: patch out polyfill.io usage, bump KaTeX
866164e 
Part of NixOS#323379

(cherry picked from commit ced695a)
@natsukium
[Backport release-24.05] vivaldi: 6.9.3447.48 -> 6.9.3447.51 (NixOS#3…
42053b4 
…47410)
@markuskowa
[24.05] rdma-core: 52.0 -> 52.1 (NixOS#347982)
f5aad11
@pbsds
[Backport release-24.05] open62541: 1.4.4 -> 1.4.6 (NixOS#348378)
d518f33
@flokli @github-actions
wire-desktop: add CVE-2024-6775 to knownVulnerabilities
92b9278 
wire-desktop on Linux uses electron 29.4.5, which is known to be
vulnerable to CVE-2024-6775:

https://github.com/wireapp/wire-desktop/blob/cf65edb5981be370f3284555512696175099e234/package.json#L85

The MacOS version is even older, and affected by this too.

(cherry picked from commit 32309e4)
@arianvp
[Backport release-24.05] wire-desktop: add CVE-2024-6775 to knownVuln…
4f954fa 
…erabilities (NixOS#348501)
@JohnRTitor
[Backport release-24.05] koboldcpp: 1.75.2 -> 1.76, add `meta.homepag…
c0b1da3 
…e` (NixOS#348295)
@DontEatOreo @github-actions
gallery-dl: 1.27.5 -> 1.27.6
948892d 
Changelog: https://github.com/mikf/gallery-dl/releases/tag/v1.27.6
Diff: mikf/gallery-dl@v1.27.5...v1.27.6
(cherry picked from commit 06923ad)
@DontEatOreo @github-actions
arc-browser: 1.61.2-54148 -> 1.63.1-54714
f8685d8 
Changelog: https://arc.net/e/8554E66E-831C-459A-B6C9-1E814AA5CCD8
(cherry picked from commit 257097b)
@LeSuisse
[Backport release-24.05] python3Packages.django-mdeditor: patch out p…
9478a20 
…olyfill.io usage, bump KaTeX (NixOS#348478)
@r-ryantm @github-actions
mattermost: 9.5.9 -> 9.5.10
ea92398 
(cherry picked from commit 7c84a25)
@Shawn8901
linux_xanmod: 6.6.54 -> 6.6.56
0af6c1b 
(cherry picked from commit 35d91eb)
@Shawn8901
linux_xanmod_latest: 6.11.2 -> 6.11.3
8929792 
(cherry picked from commit bd50ef4)
@mweinelt @github-actions
firefox-unwrapped: 131.0.2 -> 131.0.3
56f2672 
https://www.mozilla.org/en-US/firefox/131.0.3/releasenotes/
(cherry picked from commit 068040b)
@mweinelt @github-actions
firefox-bin-unwrapped: 131.0.2 -> 131.0.3
2bcd284 
https://www.mozilla.org/en-US/firefox/131.0.3/releasenotes/
(cherry picked from commit 82f08f3)
@kirillrdy
[Backport release-24.05] oink: 1.3.0 -> 1.3.1 (NixOS#348349)
1988382
@mweinelt
mediawiki: 1.41.3 -> 1.41.4
c0327d8 
https://www.mediawiki.org/wiki/Release_notes/1.41#MediaWiki_1.41.4
@JohnRTitor
[Backport release-24.05] gallery-dl: 1.27.5 -> 1.27.6 (NixOS#348525)
bad1aa1
@NickCao
[Backport release-24.05] arc-browser: 1.61.2-54148 -> 1.63.1-54714 (N…
8eec6bb 
…ixOS#348573)
@guoard @teutat3s
docker_27: 27.1.1 -> 27.2.0
574d2ff 
(cherry picked from commit 755657b)
@Parsifa1 @teutat3s
docker_27: 27.2.0 -> 27.3.0
b493b0e 
(cherry picked from commit aae4960)
@r-ryantm @teutat3s
docker: 27.3.0 -> 27.3.1
7f56f21 
(cherry picked from commit e55b3cf)
@roberth @infinisil
shell.nix: Enable e.g. --arg nixpkgs ./.
b112355 
This allows shell.nix to be run with the latest tools instead of
the pinned ones when desired, which is probably not very often,
but useful nonetheless.

(cherry picked from commit b07c441)
@infinisil
ci: Add default.nix with exposed pkgs
4bedbf8 
Allows reusing it in more places

(cherry picked from commit 1700d00)
@infinisil
ci: Add review request scripts
2eb82ca 
Also post a comment in case base branch is wrong
  This guides newcomers in how to smoothly handle the potentially scary
  situation of having thousands of commits listed in a PR.

  While CI shows the same, people might not even look at CI if the PR
  looks botched.

(cherry picked from commit 369cfa0)
@infinisil
ci: Add codeowners validator
1a317c0 
(cherry picked from commit 5695bf6)
@infinisil
workflows/codeowners: init
5de26ba 
(cherry picked from commit 87a2986)
@infinisil
OWNERS: placeholder init
2211c10 
(cherry picked from commit 93dcd42)
@github-actions github-actions bot added 6.topic: printing 6.topic: rust 6.topic: policy discussion 6.topic: golang 6.topic: ruby 6.topic: vim 6.topic: ocaml 6.topic: fetch 6.topic: steam 6.topic: stdenv Standard environment 6.topic: nodejs 6.topic: pantheon The Pantheon desktop environment 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: lua 6.topic: testing Tooling for automated testing of packages and modules 6.topic: systemd 6.topic: LXQt The Lightweight Qt Desktop Environment 6.topic: vscode 6.topic: flakes The experimental Nix feature 6.topic: lib The Nixpkgs function library 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: julia 6.topic: php 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: k3s Kubernates distribution (https://k3s.io/) 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: dotnet Language: .NET labels Oct 28, 2024
@m1-s m1-s closed this Oct 28, 2024
@nix-owners
Copy link

nix-owners bot commented Oct 28, 2024

The PR's base branch is set to master, but 5993 commits from the release-24.05 branch are included. Make sure you know the right base branch for your changes, then:

  • If the changes should go to the release-24.05 branch, change the base branch to release-24.05
  • If the changes should go to the master branch, rebase your PR onto the merge base with the master branch: 
    # git rebase --onto $(git merge-base upstream/master HEAD) $(git merge-base upstream/release-24.05 HEAD)
git rebase --onto 0b49ef697b3e5cff1e6f18033de2b422e2fe1f43 cd3e8833d70618c4eea8df06f95b364b016d4950
git push --force-with-lease

@infinisil
Copy link
Member

@m1-s No need to close such PRs anymore btw, the bot's message can be followed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: dotnet Language: .NET 6.topic: emacs Text editor 6.topic: fetch 6.topic: flakes The experimental Nix feature 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: julia 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: k3s Kubernates distribution (https://k3s.io/) 6.topic: kernel The Linux kernel 6.topic: lib The Nixpkgs function library 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: lua 6.topic: LXQt The Lightweight Qt Desktop Environment 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nodejs 6.topic: ocaml 6.topic: pantheon The Pantheon desktop environment 6.topic: php 6.topic: policy discussion 6.topic: printing 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment 6.topic: steam 6.topic: systemd 6.topic: testing Tooling for automated testing of packages and modules 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: vim 6.topic: vscode 8.has: changelog 8.has: documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (update) This PR changes an existing module in `nixos/`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.