Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docker and podman anchor on CUDA section #352365

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

ereslibre
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ereslibre
Copy link
Member Author

@SomeoneSerge I thought I had more things pending on the documentation side but I think this is the only comment that was pending from your side. Please let me know if I overlooked something.

As promised I'll check how to improve the implementation with a proper closure support.

@ereslibre ereslibre changed the title docs: update docker and podman on CUDA section docs: update docker and podman anchor on CUDA section Oct 30, 2024
@SomeoneSerge
Copy link
Contributor

As promised I'll check how to improve the implementation with a proper closure support.

I forget if I mentioned but it's a similar problem in nix-required-mounts (it's using exportReferencesGraph but it could be still more general than that) and we should probably write a more abstract tool solving both tasks so we can test it better...

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 30, 2024
@SomeoneSerge SomeoneSerge merged commit 0510f26 into NixOS:master Oct 30, 2024
28 checks passed
@ereslibre ereslibre deleted the update-cuda-documentaiton branch October 30, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants