Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-24.05] nix: fix macOS sandbox escape via builtin builders #352456

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Oct 30, 2024

fixes
GHSA-wf4c-57rh-9pjg

Backport of #352455

(cherry picked from commit 2f6dc5c)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@LeSuisse LeSuisse added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Oct 30, 2024
@emilazy
Copy link
Member

emilazy commented Oct 30, 2024

Building on aarch64-linux. (actually the non‐backport)

@Mic92
Copy link
Member Author

Mic92 commented Oct 30, 2024

@emilazy ofborg is running this already btw. So both x86/arm64 already work.

@emilazy emilazy merged commit 5c3c008 into NixOS:release-24.05 Oct 30, 2024
26 of 30 checks passed
@Mic92 Mic92 deleted the advisory-fix-1-backport branch October 30, 2024 20:51
@emilazy
Copy link
Member

emilazy commented Oct 30, 2024

The Nix builds for nixpkgs-24.05-darwin have finished, so the fallback paths for those could be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants