Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

localsend: 1.15.4-unstable-2024-10-26 -> 1.16.1 #353481

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

localsend: 1.15.4-unstable-2024-10-26 -> 1.16.1 #353481

wants to merge 2 commits into from
+974 −162

Conversation

aucub
Copy link
Contributor

@aucub aucub commented Nov 3, 2024 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from sikmir, linsui and Pandapip1 November 4, 2024 09:53
@aucub aucub requested a review from linsui November 4, 2024 14:10
linsui
linsui reviewed Nov 4, 2024
View reviewed changes
pkgs/by-name/lo/localsend/package.nix
};

sourceRoot = "${src.name}/app";

pubspecLock = lib.importJSON ./pubspec.lock.json;

customSourceBuilders = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this in https://github.com/NixOS/nixpkgs/tree/master/pkgs/development/compilers/dart/package-source-builders, same for hiddify...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems beyond my capabilities. I just copied these from Rune.

@ofborg ofborg bot requested a review from linsui November 5, 2024 00:14
@sikmir
Copy link
Member

sikmir commented Nov 6, 2024

1.16.1 is out

@aucub
Copy link
Contributor Author

aucub commented Nov 6, 2024

1.16.1 is out

Should we continue making changes here, or close this PR and have someone else separate the customSourceBuilders?

@sikmir
Copy link
Member

sikmir commented Nov 6, 2024

Should we continue making changes here

Yes, that's fine.

@aucub aucub changed the title localsend: 1.15.4-unstable-2024-10-26 -> 1.16.0 localsend: 1.15.4-unstable-2024-10-26 -> 1.16.1 Nov 6, 2024
@0n-s 0n-s mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir Awaiting requested review from sikmir

@Pandapip1 Pandapip1 Awaiting requested review from Pandapip1

@linsui linsui Awaiting requested review from linsui

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

localsend: goes black after sending a file
3 participants
@aucub @sikmir @linsui