Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vencord: 1.10.5 -> 1.10.6 #354045

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Infinidoge
Copy link
Contributor

Discord broke things recently, update required

Things done

Trivial bump

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@DontEatOreo
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 354045


x86_64-darwin

✅ 2 packages built:
  • vencord
  • vencord-web-extension

aarch64-darwin

✅ 2 packages built:
  • vencord
  • vencord-web-extension

Copy link
Member

@DontEatOreo DontEatOreo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I was having issues on my side only, thanks for the PR!

LGTM!

@Infinidoge
Copy link
Contributor Author

Discord updates and breaks often enough that I don't actually get Vencord from Nixpkgs directly anymore, I override the src with a flake input lmao. I got through updating it in Nixpkgs before I remembered I did that though, so contributed it anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants