tiny-cuda-nn: fix a couple of build issues #359664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CUDA architecture detection code in tiny-cuda-nn's Torch bindings convert CUDA capabilities to `int`s, which breaks with 9.0a. Filter 9.0a from the CUDA capabilities passed to TCNN_CUDA_ARCHITECTURES. Also patch the Torch bindings to replace the hardcoded `-std=c++14` argument to nvcc with `-std=c++17` for CUDA 11+ to fix the build.
ofborg
bot
added
10.rebuild-darwin: 0
|
Tentatively I’ll say this looks good; I haven’t had a chance to build or test running this yet. |
|
I was able to run |
ConnorBaker
approved these changes
Dec 2, 2024
wegank
added
12.approved-by: package-maintainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CUDA architecture detection code in tiny-cuda-nn's Torch bindings convert CUDA capabilities to
ints, which breaks with 9.0a. Filter 9.0a from the CUDA capabilities passed toTCNN_CUDA_ARCHITECTURES. Also patch the Torch bindings to replace the hardcoded-std=c++14argument to nvcc with-std=c++17for CUDA 11+ to fix the build.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.