dnote: init at 0.15.1 #366799
Open
dnote: init at 0.15.1 #366799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bot-wxt1221
force-pushed
the
dnote
branch
2 times, most recently
from
8f7ca5d to
37935f6
Compare
Bot-wxt1221
force-pushed
the
dnote
branch
2 times, most recently
from
a7ce60d to
5ef2499
Compare
|
@ofborg eval |
ofborg
bot
added
8.has: package (new)
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4986 |
nixpkgs-reviewd workflow started
TARGETS
Status and logs: https://github.com/Bot-wxt1221/nixpkgs-reviewd/actions/runs/12453490143 |
|
|
|
| meta = { | ||
| homepage = "https://www.getdnote.com/"; | ||
| description = "Simple command line notebook for programmers"; | ||
| changelog = "https://github.com/dnote/dnote/blob/master/CHANGELOG.md"; |
There was a problem hiding this comment.
Suggested change
| changelog = "https://github.com/dnote/dnote/blob/master/CHANGELOG.md"; | |
| changelog = "https://github.com/dnote/dnote/blob/cli-v${version}/CHANGELOG.md"; |
| ]; | ||
|
|
||
| preBuild = '' | ||
| patchShebangs . |
There was a problem hiding this comment.
Can we limit that to some files/directories?
There was a problem hiding this comment.
Look at build logs, lots of script has patched in almost every directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #366605
Fix #366604
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.