Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

immersed: 10.5.0 -> 10.6.0 #367765

Open
wants to merge 1 commit into
base: nixos-24.11
Choose a base branch
from
Open

Conversation

Bakan0
Copy link

@Bakan0 Bakan0 commented Dec 23, 2024

Things done

  • Built on platform(s)
    • [ ✅] x86_64-linux
    • aarch64-linux
    • [ ✅] x86_64-darwin (I did not check these, as I do not have a Mac, but according to the previous package, this appears to be true)
    • [ ✅] aarch64-darwin (I did not check these, as I do not have a Mac, but according to the previous package, this appears to be true)
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • [ ✅] Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Dec 23, 2024
@lucasewd
Copy link

@lucasew
Copy link
Contributor

lucasew commented Dec 23, 2024

Also, please join (squash) your commits and rename to immersed: 10.5.0 -> 10.6.0.

@Bakan0
Copy link
Author

Bakan0 commented Dec 23, 2024

I sure hope I did that correctly.

@lucasewd
Copy link

@lucasewd
Copy link

@lucasew
Copy link
Contributor

lucasew commented Dec 23, 2024

I sure hope I did that correctly.

It seems alright. I didn't test the package. Let's see what CI has to say.

@lucasew
Copy link
Contributor

lucasew commented Dec 23, 2024

BTW please also rename the PR, same name as the commit

@Bakan0 Bakan0 changed the title immersed: Update linux and darwin versions from 10.5.0 to 10.6.0 immersed: 10.5.0 -> 10.6.0 Dec 23, 2024
@lucasewd
Copy link

nixpkgs-reviewd workflow finished

Status and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12474295102

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367765


x86_64-darwin

✅ 1 package built:
  • immersed

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367765


aarch64-darwin

✅ 1 package built:
  • immersed

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367765


x86_64-linux

✅ 1 package built:
  • immersed

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-december/1711/26

@Bakan0
Copy link
Author

Bakan0 commented Dec 24, 2024

@ofborg test immersed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants