-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
immersed: 10.5.0 -> 10.6.0 #367765
base: nixos-24.11
Are you sure you want to change the base?
immersed: 10.5.0 -> 10.6.0 #367765
Conversation
nixpkgs-reviewd workflow startedStatus and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12474157699 |
Also, please join (squash) your commits and rename to |
e49ade6
to
ba67108
Compare
I sure hope I did that correctly. |
nixpkgs-reviewd workflow finishedStatus and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12474157699 |
nixpkgs-reviewd workflow startedStatus and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12474295102 |
It seems alright. I didn't test the package. Let's see what CI has to say. |
BTW please also rename the PR, same name as the commit |
nixpkgs-reviewd workflow finishedStatus and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12474295102
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review-december/1711/26 |
@ofborg test immersed |
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.