linux/common-config: Make backlight device support built-in #367774
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of
CONFIG_BACKLIGHT_CLASS_DEVICE
must be the same as that ofCONFIG_DRM
, so that backlight devices can be properly attached to their respective DRM panels.Arch also does the same.
Longer Explanation
In
include/drm/drm_panel.h
,drm_panel_of_backlight
is a function that finds the corresponding backlight in the device tree and attaches it to the DRM panel. IfCONFIG_DRM
is built-in butCONFIG_BACKLIGHT_CLASS_DEVICE
isn't, the function simply becomes noop:In a broken setup, if the backlight isn't powered on already before the kernel is started, setting the brightness from userspace has no effect since
backlight_get_brightness
will be hard-wired to return 0. Depending on the hardware, there can be no way to enable the backlight (thus "unblanking" it) from userspace.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.