Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{libsForQt5,kdePackages}.{partitionmanager,kpmcore}: drop ReiserFS support #368474

Merged
merged 2 commits into from
Dec 27, 2024
Merged

{libsForQt5,kdePackages}.{partitionmanager,kpmcore}: drop ReiserFS support #368474

merged 2 commits into from
Dec 27, 2024

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Dec 27, 2024

Things done

As discussed in #367696 (comment).
Fixes #367696

I also marked reiser4progs as broken unless someone wanna fix it later. It produces a non-trivial type error, where the function parameter order is incorrect. I don't want to fix it since it's unmaintained anyway.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@oxalica
{libsForQt5,kdePackages}.{partitionmanager,kpmcore}: drop ReiserFS su…
c22f137 
…pport

ReiserFS has not been actively maintained for many years. It has been
marked as obsolete since Linux 6.6, and is removed in the next 6.13
release.
@oxalica
reiser4progs: mark as broken
a3464a4
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Dec 27, 2024
@oxalica oxalica mentioned this pull request Dec 27, 2024
Closed
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 27, 2024
@oxalica oxalica mentioned this pull request Dec 27, 2024
Open
@K900 K900 merged commit 26b95a4 into NixOS:master Dec 27, 2024
24 of 25 checks passed
@oxalica oxalica deleted the fix/partition-manager-drop-reiserfs branch December 27, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K900 K900 Awaiting requested review from K900

@NickCao NickCao Awaiting requested review from NickCao

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: reiser4progs and partitionmanager after staging-next 2024-12-04 #361878
2 participants
@oxalica @K900