-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mono: fix build on gcc 14 #370711
mono: fix build on gcc 14 #370711
Conversation
Looks like we are about eight years behind? https://github.com/mono/gtk-sharp/releases |
|
Or, hmm, I guess 2.12 is for GTK 2? But still it seems like we’re on a release from 2014 when there are upstream commits from 2020? We should probably bump; maybe it’ll even fix the issue. Edit: Actually it seems like https://github.com/GLibSharp/GtkSharp is the repo for GTK 3, and there’s a release from 2021 and commits from a year ago. |
|
I think I'd rather just fix the GCC breakage for now. Perhaps someone who maintains a dependent package would be interested in maintaining it. |
98bf3f7
to
9e09e53
Compare
|
We’re still shipping complex JIT runtimes and application frameworks that were already EOL five to seven years ago? We should probably remove the old Mono versions, not fix them… |
8787f83
to
5f73322
Compare
|
I wouldn't object to that, but there are a bunch of leaf packages here. We'd want to at least consult the maintainers. So far it looks like this PR will fix builds of 15 packages. The remaining are either existing failures unrelated to GCC 14 ( |
There’s no in‐tree users of |
5f73322
to
32c5435
Compare
|
This should now fix everything broken by GCC 14. I'm not against trying to remove these old mono versions, but I'd like to get fixes in first, in case we want to bisect future changes. |
This was broken in the last staging update via gcc 13 -> 14.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.