pinentry-dmenu: init at 0.2.2 #387479
Open
pinentry-dmenu: init at 0.2.2 #387479
+71
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
8.has: maintainer-list (update)
ethancedwards8
suggested changes
Mar 7, 2025
Comment on lines
24
to
26
| repo = finalAttrs.pname; | ||
| rev = finalAttrs.version; | ||
| sha256 = "sha256-FmP9tI/oU7VM8x+Wu6bbeg1CVopZc6oOWnd4qUptVV8="; |
There was a problem hiding this comment.
Suggested change
| repo = finalAttrs.pname; | |
| rev = finalAttrs.version; | |
| sha256 = "sha256-FmP9tI/oU7VM8x+Wu6bbeg1CVopZc6oOWnd4qUptVV8="; | |
| repo = "pinentry-dmenu"; | |
| tag = finalAttrs.version; | |
| hash = "sha256-FmP9tI/oU7VM8x+Wu6bbeg1CVopZc6oOWnd4qUptVV8="; |
use of pname like that is discouraged as it breaks overrides
| ) | ||
| ''; | ||
|
|
||
| meta = with lib; { |
There was a problem hiding this comment.
remove with lib; as it increases eval times
| meta = with lib; { | ||
| description = "Pinentry implementation based on dmenu"; | ||
| homepage = "https://github.com/ritze/pinentry-dmenu"; | ||
| license = licenses.gpl2; |
There was a problem hiding this comment.
Suggested change
| license = licenses.gpl2; | |
| license = licenses.gpl2Only; |
|
|
||
| meta = with lib; { | ||
| description = "Pinentry implementation based on dmenu"; | ||
| homepage = "https://github.com/ritze/pinentry-dmenu"; |
There was a problem hiding this comment.
Suggested change
| homepage = "https://github.com/ritze/pinentry-dmenu"; | |
| homepage = "https://github.com/ritze/pinentry-dmenu"; | |
| changelog = "https://github.com/ritze/pinentry-dmenu/releases/tag/${finalAttrs.version}"; |
|
done, should I squash? |
|
Yes please |
sweiglbosker
force-pushed
the
pinentry-dmenu
branch
2 times, most recently
from
21f508f to
d730cd6
Compare
|
Ok, it should be ok? |
|
The maintainer commit should be first |
pinentry-dmenu: refactor to use finalAttrs pattern pinentry-dmenu: refactor pinentry-dmenu: init at 0.2.2
sweiglbosker
force-pushed
the
pinentry-dmenu
branch
from
d730cd6 to
b5fd591
Compare
|
done |
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added package for pinentry-dmenu, a pinentry fronted based on dmenu.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.