codimd: build with nodejs-8_x #59118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff regenerates the package sets for `codimd` and `codemirror` using NodeJS 8 to get rid of the deprecated[1] `nodejs-6_x`. Additionally the following issues had to be fixed during the update: * The package `js-sequence-diagram` has been removed from the NPM registry and was replaced by a security holding package[2]. The package was published by a third-party (upstream only supports bower builds), so it's unclear whether the package will re-appear[3]. As the tarballs still exist (and the hash didn't change), the package will be loaded manually into the build env. * For the babel-related packages, `dontNpmInstall` will be set for `node2nix` installs as some of those packages bundle a `package-lock.json` that triggers `ENOTCACHED` errors for optional dependencies[4]. For now it should be sufficient to use NodeJS 8 (`codimd` v1.2.x doesn't support NodeJS 10), in the long term we probably want to use `yarn2nix` here with NodeJS 10. This is much rather a fix to get rid of another NodeJS 6 dependency. [1] `nodejs-6_x` is about to be deprecated, see NixOS#58976 [2] https://www.npmjs.com/package/js-sequence-diagrams, https://github.com/npm/security-holder [3] bramp/js-sequence-diagrams#212 [4] svanderburg/node2nix#134
GrahamcOfBorg
added
10.rebuild-darwin: 0
|
/cc maintainer @WilliButz. |
|
@GrahamcOfBorg test codimd |
lheckemann
pushed a commit
that referenced
this pull request
Apr 7, 2019
This diff regenerates the package sets for `codimd` and `codemirror` using NodeJS 8 to get rid of the deprecated[1] `nodejs-6_x`. Additionally the following issues had to be fixed during the update: * The package `js-sequence-diagram` has been removed from the NPM registry and was replaced by a security holding package[2]. The package was published by a third-party (upstream only supports bower builds), so it's unclear whether the package will re-appear[3]. As the tarballs still exist (and the hash didn't change), the package will be loaded manually into the build env. * For the babel-related packages, `dontNpmInstall` will be set for `node2nix` installs as some of those packages bundle a `package-lock.json` that triggers `ENOTCACHED` errors for optional dependencies[4]. For now it should be sufficient to use NodeJS 8 (`codimd` v1.2.x doesn't support NodeJS 10), in the long term we probably want to use `yarn2nix` here with NodeJS 10. This is much rather a fix to get rid of another NodeJS 6 dependency. [1] `nodejs-6_x` is about to be deprecated, see #58976 [2] https://www.npmjs.com/package/js-sequence-diagrams, https://github.com/npm/security-holder [3] bramp/js-sequence-diagrams#212 [4] svanderburg/node2nix#134 (cherry picked from commit 5feec42, PR #59118)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This diff regenerates the package sets for
codimdandcodemirrorusing NodeJS 8 to get rid of the deprecated[1]
nodejs-6_x.Additionally the following issues had to be fixed during the update:
The package
js-sequence-diagramhas been removed from the NPMregistry and was replaced by a security holding package[2]. The
package was published by a third-party (upstream only supports bower
builds), so it's unclear whether the package will re-appear[3].
As the tarballs still exist (and the hash didn't change), the package
will be loaded manually into the build env.
For the babel-related packages,
dontNpmInstallwill be set fornode2nixinstalls as some of those packages bundle apackage-lock.jsonthat triggersENOTCACHEDerrors for optionaldependencies[4].
For now it should be sufficient to use NodeJS 8 (
codimdv1.2.x doesn'tsupport NodeJS 10), in the long term we probably want to use
yarn2nixhere with NodeJS 10. This is much rather a fix to get rid of another
NodeJS 6 dependency.
[1]
nodejs-6_xis about to be deprecated, see #58976[2] https://www.npmjs.com/package/js-sequence-diagrams,
https://github.com/npm/security-holder
[3] bramp/js-sequence-diagrams#212
[4] svanderburg/node2nix#134
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)