Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.funcsigs: fix tests on pypy3 #61529

Merged

Conversation

thoughtpolice
Copy link
Member

Motivation for this change

This package has a spurious test failure on PyPy3, which was reported
upstream a while ago: testing-cabal/funcsigs#10

This is fixed thanks to the included patch, which was authored and is
also used by the Gentoo Python team.

With this, packages like 'pytest' and 'click' now work under PyPy3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This package has a spurious test failure on PyPy3, which was reported
upstream a while ago:

     testing-cabal/funcsigs#10

This is fixed thanks to the included patch, which was authored and is
also used by the Gentoo Python team.

With this, packages like 'pytest' and 'click' now work under PyPy3.

Signed-off-by: Austin Seipp <[email protected]>
@thoughtpolice thoughtpolice requested a review from FRidh as a code owner May 15, 2019 02:59
@thoughtpolice thoughtpolice self-assigned this May 15, 2019
@ofborg ofborg bot added 6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 15, 2019
@thoughtpolice
Copy link
Member Author

@GrahamcOfBorg build pypy3Packages.funcsigs pypy3Packages.click

@thoughtpolice thoughtpolice merged commit b0c2352 into NixOS:master May 15, 2019
@thoughtpolice thoughtpolice deleted the nixpkgs/pypy3-fix-funcsigs branch May 15, 2019 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant