Companions - WIP

[SalmanTKhan]

• Base Implementation

• Loading/Saving both in Barracks and Zone Server
• Able to mount companions with proper class (Falcon/Flying pets don't work yet).

• Known Issues

• Changing maps while riding, you have to remount the companion.
  Companion list in barracks works for one companion; after that, it breaks.
  Companion Buff Logic has to be refactored.

[exectails]

Thanks for the PR! I'm going to convert this to a draft for now, because of the known issues, which sound like this isn't quite ready to be pulled into master. The barracks issue in particular sounds like the packet(s) aren't correct yet. Did you base your implementation on logs or is the structure guessed?

[SalmanTKhan]

Thanks for the PR! I'm going to convert this to a draft for now, because of the known issues, which sound like this isn't quite ready to be pulled into master. The barracks issue in particular sounds like the packet(s) aren't correct yet. Did you base your implementation on logs or is the structure guessed?

Sounds good.

As always based-off packet logs and then guessed, because you know there are certain nuances like a byte + 3 gap/filler bytes, that are common in ToS packet structure, that I tend to miss. There used to be Pet Weapon/Armor slots in the Barrack PetInfo packet but as you know IMC removed them and now I have no clue what's in there. The structure seems fine in the packet template but when applying it to the actual in-game, it doesn't work.

[exectails]

Based on the discussion on Discord, it seems like the second known issue is fixed now, and I also see a commit addressing buff issues. Does that mean only the first known issue (remounting) is left?

[SalmanTKhan]

Based on the discussion on Discord, it seems like the second known issue is fixed now, and I also see a commit addressing buff issues. Does that mean only the first known issue (remounting) is left?

That is correct