fix: pass build info as buffer #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7726626 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agostbiro
had a problem deploying
to
github-action-benchmark
GitHub Actions
Error
agostbiro
commented
Jan 29, 2025
crates/edr_napi/src/provider.rs
Outdated
| #[napi(object)] | ||
| pub struct TracingConfigWithBuffers { | ||
| /// Build information to use for decoding contracts. | ||
| pub build_infos: Option<Vec<Uint8Array>>, |
There was a problem hiding this comment.
Wrapping in an Option is a change from the design doc, but it maintains backwards compatibility as the TracingConfig in Hardhat has the buildInfo as an optional parameter.
agostbiro
temporarily deployed
to
github-action-benchmark
GitHub Actions
Inactive
fvictorio
approved these changes
Jan 30, 2025
agostbiro
temporarily deployed
to
github-action-benchmark
GitHub Actions
Inactive
agostbiro
had a problem deploying
to
github-action-benchmark
GitHub Actions
Error
agostbiro
temporarily deployed
to
github-action-benchmark
GitHub Actions
Inactive
agostbiro
temporarily deployed
to
github-action-benchmark
GitHub Actions
Inactive
agostbiro
temporarily deployed
to
github-action-benchmark
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass build info in tracing config as buffer to avoid FFI copy overhead.
Also upgraded to Hardhat 2.22.18 and added a patch with the changes needed in Hardhat.
Draft PR in Hardhat with the required changes: https://github.com/NomicFoundation/hardhat/pull/6200/files