Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review remaining TODO comments #1251

Merged
merged 1 commit into from
Feb 20, 2025
Merged

review remaining TODO comments #1251

merged 1 commit into from
Feb 20, 2025

Conversation

OmarTawfik
Copy link
Contributor

Doing a quick pass before the next release to see if we need to fix anything.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: c20a33a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OmarTawfik OmarTawfik mentioned this pull request Feb 14, 2025
Merged
@OmarTawfik OmarTawfik marked this pull request as ready for review February 14, 2025 23:28
@OmarTawfik OmarTawfik requested review from a team as code owners February 14, 2025 23:28
@OmarTawfik OmarTawfik enabled auto-merge February 14, 2025 23:29
ggiraldez
ggiraldez approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@ggiraldez ggiraldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

github-merge-queue bot pushed a commit that referenced this pull request Feb 19, 2025
@OmarTawfik
reduce scanner string allocations (#1248)
00b438b 
Found while cleaning up the remaining `TODO` comments before the release
(see #1251).
Fixed This one since it was a minor change to stop allocating strings on
every scanner invocation.

Closes #1001
@OmarTawfik
review remaining TODO comments
c20a33a 
Doing a quick pass before the next release to see if we need to fix anything.
@OmarTawfik OmarTawfik added this pull request to the merge queue Feb 20, 2025
Merged via the queue into NomicFoundation:main with commit e564e80 Feb 20, 2025
2 checks passed
@OmarTawfik OmarTawfik deleted the remove-todos branch February 20, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggiraldez ggiraldez ggiraldez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OmarTawfik @ggiraldez