Fix global using extensions propagation across multiple files
#1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes NomicFoundation#1249 Global extensions were being hooked directly to the source unit's lexical scope instead of using a proper extensions scope. That meant it would only apply if the type reference was located in the same file as the `using` directive and would break eg. for functions in imported files returning the extended type.
|
OmarTawfik
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1249
Global extensions were being hooked directly to the source unit's lexical scope instead of using a proper extensions scope. That meant it would only apply if the type reference was located in the same file as the
usingdirective and would break eg. for functions in imported files returning the extended type.