Feature/prod 2955/add traces to hz cache #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added ProcessExpiredEviction
…ache # Conflicts: # HzMemoryCache/HzMemoryCache.cs
JoelNygren-Norce
requested review from
aheintz,
patrik-j-nilsson,
johan-bjerling,
duerdod,
johan-ketels,
Tarek-Alzein and
sigdro
| { | ||
| public static class HzCacheDiagnostics | ||
| { | ||
| public const string HzCacheVersion = "0.0.9"; |
There was a problem hiding this comment.
Surely this will be 0.0.10 once this is merged?
There was a problem hiding this comment.
maby we should remove this as no one will keep it updated?
johan-bjerling
approved these changes
Nov 26, 2024
patrik-j-nilsson
requested changes
Nov 26, 2024
There was a problem hiding this comment.
I think it's a bit unnecessary to have a dependency on OpenTelemetry in this package, then we need to keep it up to date here as well.
The extension method is a nice idea, but I fear it could create more problems than it's worth.
It should be as simple as adding builder.AddSource(HzCacheDiagnostics.ActivitySourceName); in the service that uses this package.
removed Extesion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.