Added code coverage.

Norconex · Jul 31, 2024 · 6677dbd · 6677dbd
1 parent d9af88a
commit 6677dbd
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 0 deletions.
diff --git a/src/main/java/com/norconex/commons/lang/bean/jackson/JsonXmlCollectionSerializer.java b/src/main/java/com/norconex/commons/lang/bean/jackson/JsonXmlCollectionSerializer.java
@@ -59,6 +59,12 @@ public class JsonXmlCollectionSerializer<T extends Collection<?>>
     private BeanProperty currentProperty;
     private final JsonSerializer<?> defaultSerializer;
 
+    //NOTE: default empty constructor required for unit test
+    JsonXmlCollectionSerializer() {
+        defaultSerializer = null;
+    }
+
+
     @Override
     public JsonSerializer<?> createContextual(
             SerializerProvider prov, BeanProperty property)

diff --git a/src/test/java/com/norconex/commons/lang/bean/jackson/JsonXmlCollectionTest.java b/src/test/java/com/norconex/commons/lang/bean/jackson/JsonXmlCollectionTest.java
@@ -17,6 +17,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatNoException;
 
+import java.io.IOException;
 import java.io.StringWriter;
 import java.util.ArrayList;
 import java.util.Collection;
@@ -28,6 +29,11 @@
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 
+import com.fasterxml.jackson.annotation.JsonInclude;
+import com.fasterxml.jackson.annotation.JsonInclude.Include;
+import com.fasterxml.jackson.core.exc.StreamWriteException;
+import com.fasterxml.jackson.databind.DatabindException;
+import com.fasterxml.jackson.databind.annotation.JsonSerialize;
 import com.norconex.commons.lang.bean.BeanMapper;
 import com.norconex.commons.lang.bean.BeanMapper.Format;
 
@@ -71,6 +77,19 @@ void testXmlTagNames() {
         );
     }
 
+    @Test
+    void testNullCollection()
+            throws StreamWriteException, DatabindException, IOException {
+        assertThatNoException().isThrownBy(() -> {
+            var out = new StringWriter();
+            var obj = new ObjectWithNullList();
+            obj.nullList = null;
+            BeanMapper.DEFAULT.write(obj, out, Format.XML);
+            BeanMapper.DEFAULT.write(obj, out, Format.JSON);
+            BeanMapper.DEFAULT.write(obj, out, Format.YAML);
+        });
+    }
+
     @Data
     static class CollectionHolder {
 
@@ -94,4 +113,10 @@ static class SomeEntry {
         private int propc;
     }
 
+    @Data
+    @JsonInclude(value = Include.ALWAYS, content = Include.ALWAYS)
+    static class ObjectWithNullList {
+        @JsonSerialize(nullsUsing = JsonXmlCollectionSerializer.class)
+        private List<String> nullList = null;
+    }
 }