Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Torque Dial Driver IO #273

Merged
merged 6 commits into from
Feb 5, 2025
Merged

Added Torque Dial Driver IO #273

merged 6 commits into from
Feb 5, 2025

Conversation

bjackson312006
Copy link
Contributor

@bjackson312006 bjackson312006 commented Feb 2, 2025 •
edited
Loading

Changes

  • Torque dial CAN messages are received in steeringio.c
  • When the dial's setting is changed, set_torque_limit() is called. The five settings are: 20%, 40%, 60%, 80%, and 100%.

Notes

  • Not tested yet

Checklist

  • No merge conflicts
  • All checks passing
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #9

@bjackson312006 bjackson312006 self-assigned this Feb 2, 2025
@bjackson312006 bjackson312006 mentioned this pull request Jan 29, 2025
Closed
caiodasilva2005
caiodasilva2005 requested changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@caiodasilva2005 caiodasilva2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a small change

Core/Src/pedals.c Outdated Show resolved Hide resolved
caiodasilva2005
caiodasilva2005 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@caiodasilva2005 caiodasilva2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bjackson312006 bjackson312006 merged commit 17439e1 into develop Feb 5, 2025
2 checks passed
@bjackson312006 bjackson312006 deleted the feature/torque_dial branch February 5, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caiodasilva2005 caiodasilva2005 caiodasilva2005 approved these changes

Assignees

@bjackson312006 bjackson312006

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Torque Dial Stuff
2 participants
@bjackson312006 @caiodasilva2005