Merge pull request #534 from Nosto/hotfix/String-typehint

Remove String typehint in URL helper
Nosto · Jul 29, 2019 · 85a5b5b · 85a5b5b
2 parents 07a5c5d + 38cd7b4
commit 85a5b5b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 All notable changes to this project will be documented in this file. This project adheres to Semantic Versioning.
 
+### 3.11.3
+* Remove function parameter type check for compatibility with PHP < 5.6
+
 ### 3.11.2
 * Implement new add multiple products to cart method to fix cart products having no image
 

diff --git a/app/code/community/Nosto/Tagging/Helper/Url.php b/app/code/community/Nosto/Tagging/Helper/Url.php
@@ -571,10 +571,10 @@ public function getNostoAddMultipleProductsToCartUrl(Mage_Core_Model_Store $stor
     /**
      * Wrapper that returns URL with action in add to cart controller
      * @param Mage_Core_Model_Store $store
-     * @param String $action
+     * @param $action
      * @return string
      */
-    protected function getAddToCartUrlByAction(Mage_Core_Model_Store $store, String $action)
+    protected function getAddToCartUrlByAction(Mage_Core_Model_Store $store, $action)
     {
         $defaultParams = $this->getUrlOptionsWithNoSid($store);
         $defaultParams[self::MAGENTO_URL_OPTION_SECURE] = 1;

diff --git a/app/code/community/Nosto/Tagging/etc/config.xml b/app/code/community/Nosto/Tagging/etc/config.xml
@@ -28,7 +28,7 @@
 <config>
     <modules>
         <Nosto_Tagging>
-            <version>3.11.2</version>
+            <version>3.11.3</version>
         </Nosto_Tagging>
     </modules>
     <global>