Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen assertion curl response test message #374

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Loosen assertion curl response test message #374

merged 1 commit into from
Jan 3, 2025

Conversation

supercid
Copy link
Member

@supercid supercid commented Jan 3, 2025

The reason this test fails is the error response string slightly change over different curl versions.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Documentation:

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non-existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

@supercid
Loosen assertion curl response test message. The reason this test fai…
257b0b6 
…ls is the error response string slightly change over different curl versions.
@supercid supercid enabled auto-merge January 3, 2025 08:02
@supercid supercid mentioned this pull request Jan 3, 2025
Open
10 tasks
@supercid supercid merged commit b9e5e1b into develop Jan 3, 2025
7 checks passed
@supercid supercid deleted the test-assert-curl-message branch January 3, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@churlevski-filip churlevski-filip churlevski-filip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supercid @churlevski-filip