SSP-160 Search analytics for nosto products sw66 #105
Conversation
bojand-soprex
changed the title
| } | ||
|
|
||
| $dataSource = $data['dataSource']; | ||
| $payload = [ |
There was a problem hiding this comment.
i think it would be a good idea to create an object for the data source within the php-sdk. This would be easier to work with, and obviously would mean that magento etc could reuse the structure of the object and what should be sent etc.
| ]; | ||
|
|
||
| try { | ||
| if ($dataSource === 'search') { |
There was a problem hiding this comment.
could use constant for search and category
| return new JsonResponse(['status' => 'success']); | ||
| } | ||
|
|
||
| return new JsonResponse(['error' => 'Failed to track analytics'], Response::HTTP_INTERNAL_SERVER_ERROR); |
There was a problem hiding this comment.
would it be a good idea to also include the actual error to the response (so it would be easier for ourselves to see what has failed when debugging merchants store)
There was a problem hiding this comment.
This means that php-sdk should maybe be void, and if something happens or fails throw the exception that would be caught here and then we can actually return the reason of the failure
That also means less code here :)
it would go as
$tracker->track($dataSource, $payload);
return new JsonResponse(['status' => 'success']);
} catch (\Exception $e) {
......
| }); | ||
|
|
||
| if (response.ok) { | ||
| console.log('Tracking successful', await response.json()); |
There was a problem hiding this comment.
we probably don't want to see console logs for info in the browser
| $dataSource = $data['dataSource']; | ||
| $payload = [ | ||
| 'query' => $data['productNumber'], | ||
| 'resultId' => $data['resultId'] ?? 'DEMODEMODEMO', |
There was a problem hiding this comment.
i think that should be the unique uuid
|
|
||
| $dataSource = $data['dataSource']; | ||
| $payload = [ | ||
| 'query' => $data['productNumber'], |
There was a problem hiding this comment.
query from what i understand https://nostosolutions.atlassian.net/wiki/spaces/HD/pages/9986605082/Front-end+analytics+ingestion
should be a search value we searched for or the category
| body: JSON.stringify({ | ||
| dataSource, | ||
| productNumber, | ||
| productId, |
There was a problem hiding this comment.
i think this currently isn't enough (we need to know if click happened due to the specific search query or from specific category depending if its search/cm tracking
| {% block element_product_listing_col_empty %} | ||
| <div class="cms-listing-col col-12"> | ||
| {% block element_product_listing_col_empty_alert %} | ||
| {% sw_include '@Storefront/storefront/utilities/alert.html.twig' with { |
There was a problem hiding this comment.
looking at previous code we had pagination here, so i fonder if thats okay?
No description provided.