Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump runnables to net9.0 #6240

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

nkolev92
Copy link
Member

@nkolev92 nkolev92 commented Jan 25, 2025

Bug

Fixes:

Description

I followed https://github.com/NuGet/NuGet.Client/blob/dev/docs/updating-target-frameworks.md and here's the diff.
You can see the complete frameworks in the details below:

-Dotnet.Integration.Test.csproj = net8.0
+Dotnet.Integration.Test.csproj = net9.0
-NuGet.Commands.FuncTest.csproj = net472;net8.0;netcoreapp3.1
+NuGet.Commands.FuncTest.csproj = net472;net9.0;netcoreapp3.1
-NuGet.Packaging.FuncTest.csproj = net472;net8.0;netcoreapp3.1
+NuGet.Packaging.FuncTest.csproj = net472;net9.0;netcoreapp3.1
-NuGet.Protocol.FuncTest.csproj = net472;net8.0;netcoreapp3.1
+NuGet.Protocol.FuncTest.csproj = net472;net9.0;netcoreapp3.1
-NuGet.Signing.CrossFramework.Test.csproj = net472;net8.0
+NuGet.Signing.CrossFramework.Test.csproj = net472;net9.0
-NuGet.XPlat.FuncTest.csproj = net8.0
+NuGet.XPlat.FuncTest.csproj = net9.0
-Microsoft.Build.NuGetSdkResolver.Test.csproj = net472;net8.0
+Microsoft.Build.NuGetSdkResolver.Test.csproj = net472;net9.0
-NuGet.Build.Tasks.Console.Test.csproj = net472;net8.0
+NuGet.Build.Tasks.Console.Test.csproj = net472;net9.0
-NuGet.Build.Tasks.Pack.Test.csproj = net472;net8.0
+NuGet.Build.Tasks.Pack.Test.csproj = net472;net9.0
-NuGet.Build.Tasks.Test.csproj = net472;net8.0
+NuGet.Build.Tasks.Test.csproj = net472;net9.0
-NuGet.CommandLine.Xplat.Tests.csproj = net8.0
+NuGet.CommandLine.Xplat.Tests.csproj = net9.0
-NuGet.Commands.Test.csproj = net472;net8.0;netcoreapp3.1
+NuGet.Commands.Test.csproj = net472;net9.0;netcoreapp3.1
-NuGet.Common.Test.csproj = net472;net8.0
+NuGet.Common.Test.csproj = net472;net9.0
-NuGet.Configuration.Test.csproj = net472;net8.0;netcoreapp3.1
+NuGet.Configuration.Test.csproj = net472;net9.0;netcoreapp3.1
-NuGet.Credentials.Test.csproj = net472;net8.0
+NuGet.Credentials.Test.csproj = net472;net9.0
-NuGet.DependencyResolver.Core.Tests.csproj = net472;net8.0;netcoreapp3.1
+NuGet.DependencyResolver.Core.Tests.csproj = net472;net9.0;netcoreapp3.1
-NuGet.Frameworks.Test.csproj = net472;net8.0
+NuGet.Frameworks.Test.csproj = net472;net9.0
-NuGet.LibraryModel.Tests.csproj = net472;net8.0
+NuGet.LibraryModel.Tests.csproj = net472;net9.0
-NuGet.PackageManagement.Test.csproj = net472;net8.0
+NuGet.PackageManagement.Test.csproj = net472;net9.0
-NuGet.Packaging.Test.csproj = net472;net8.0;netcoreapp3.1
+NuGet.Packaging.Test.csproj = net472;net9.0;netcoreapp3.1
-NuGet.ProjectModel.Test.csproj = net472;net8.0;netcoreapp3.1
+NuGet.ProjectModel.Test.csproj = net472;net9.0;netcoreapp3.1
-NuGet.Protocol.Tests.csproj = net472;net8.0;netcoreapp3.1
+NuGet.Protocol.Tests.csproj = net472;net9.0;netcoreapp3.1
-NuGet.Resolver.Test.csproj = net472;net8.0;netcoreapp3.1
+NuGet.Resolver.Test.csproj = net472;net9.0;netcoreapp3.1
-NuGet.Shared.Tests.csproj = net472;net8.0
+NuGet.Shared.Tests.csproj = net472;net9.0
-NuGet.Versioning.Test.csproj = net472;net8.0
+NuGet.Versioning.Test.csproj = net472;net9.0
-TestablePlugin.csproj = net472;net8.0;netcoreapp3.1
+TestablePlugin.csproj = net472;net9.0;netcoreapp3.1
-Microsoft.Internal.NuGet.Testing.SignedPackages.csproj = net472;net8.0;netcoreapp3.1
+Microsoft.Internal.NuGet.Testing.SignedPackages.csproj = net472;net9.0;netcoreapp3.1
-Test.Utility.csproj = net472;net8.0;netcoreapp3.1
+Test.Utility.csproj = net472;net9.0;netcoreapp3.1
-Microsoft.Build.NuGetSdkResolver.csproj = net472;net8.0
+Microsoft.Build.NuGetSdkResolver.csproj = net472;net9.0
-NuGet.Build.Tasks.Console.csproj = net472;net8.0
+NuGet.Build.Tasks.Console.csproj = net472;net9.0
-NuGet.Build.Tasks.csproj = net472;net8.0
+NuGet.Build.Tasks.csproj = net472;net9.0
-NuGet.CommandLine.XPlat.csproj = net8.0
+NuGet.CommandLine.XPlat.csproj = net9.0

I also had to fix some obsolete constructor usage in the new utility project.
Followed the same pattern as #5911

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

Frameworks before:

msbuild .\build\build.proj /t:GetAllTargetFrameworks /v:m /restore:false

  NuGet.CommandLine.FuncTest.csproj = net472
  NuGet.MSSigning.Extensions.FuncTest.csproj = net472
  NuGet.CommandLine.Test.csproj = net472
  NuGet.Indexing.Test.csproj = net472
  NuGet.MSSigning.Extensions.Test.csproj = net472
  NuGet.PackageManagement.UI.Test.csproj = net472
  NuGet.PackageManagement.VisualStudio.Test.csproj = net472
  NuGet.SolutionRestoreManager.Test.csproj = net472
  NuGet.Tools.Test.csproj = net472
  NuGet.VisualStudio.Common.Test.csproj = net472
  NuGet.VisualStudio.Implementation.Test.csproj = net472
  NuGet.VisualStudio.Internal.Contracts.Test.csproj = net472
  NuGet.VisualStudio.Test.csproj = net472
  NuGetConsole.Host.PowerShell.Test.csproj = net472
  Dotnet.Integration.Test.csproj = net9.0
  Msbuild.Integration.Test.csproj = net472
  NuGet.Commands.FuncTest.csproj = net472;net9.0;netcoreapp3.1
  NuGet.Packaging.FuncTest.csproj = net472;net9.0;netcoreapp3.1
  NuGet.Protocol.FuncTest.csproj = net472;net9.0;netcoreapp3.1
  NuGet.Signing.CrossFramework.Test.csproj = net472;net9.0
  NuGet.XPlat.FuncTest.csproj = net9.0
  Microsoft.Build.NuGetSdkResolver.Test.csproj = net472;net9.0
  NuGet.Build.Tasks.Console.Test.csproj = net472;net9.0
  NuGet.Build.Tasks.Pack.Test.csproj = net472;net9.0
  NuGet.Build.Tasks.Test.csproj = net472;net9.0
  NuGet.CommandLine.Xplat.Tests.csproj = net9.0
  NuGet.Commands.Test.csproj = net472;net9.0;netcoreapp3.1
  NuGet.Common.Test.csproj = net472;net9.0
  NuGet.Configuration.Test.csproj = net472;net9.0;netcoreapp3.1
  NuGet.Credentials.Test.csproj = net472;net9.0
  NuGet.DependencyResolver.Core.Tests.csproj = net472;net9.0;netcoreapp3.1
  NuGet.Frameworks.Test.csproj = net472;net9.0
  NuGet.LibraryModel.Tests.csproj = net472;net9.0
  NuGet.PackageManagement.Test.csproj = net472;net9.0
  NuGet.Packaging.Test.csproj = net472;net9.0;netcoreapp3.1
  NuGet.ProjectModel.Test.csproj = net472;net9.0;netcoreapp3.1
  NuGet.Protocol.Tests.csproj = net472;net9.0;netcoreapp3.1
  NuGet.Resolver.Test.csproj = net472;net9.0;netcoreapp3.1
  NuGet.Shared.Tests.csproj = net472;net9.0
  NuGet.Versioning.Test.csproj = net472;net9.0
  API.Test.csproj = net472
  GenerateLicenseList.csproj = net8.0
  GenerateTestPackages.csproj = net472
  SampleCommandLineExtensions.csproj = net472
  TestableCredentialProvider.csproj = net472
  TestablePlugin.csproj = net472;net9.0;netcoreapp3.1
  Microsoft.Internal.NuGet.Testing.SignedPackages.csproj = net472;net9.0;netcoreapp3.1
  Test.Utility.csproj = net472;net9.0;netcoreapp3.1
  NuGet.CommandLine.csproj = net472
  NuGet.Console.csproj = net472
  NuGet.Indexing.csproj = net472
  NuGet.MSSigning.Extensions.csproj = net472
  NuGet.PackageManagement.PowerShellCmdlets.csproj = net472
  NuGet.PackageManagement.UI.csproj = net472
  NuGet.PackageManagement.VisualStudio.csproj = net472
  NuGet.SolutionRestoreManager.csproj = net472
  NuGet.Tools.csproj = net472
  NuGet.VisualStudio.Client.csproj = net472
  NuGet.VisualStudio.Common.csproj = net472
  NuGet.VisualStudio.Contracts.csproj = netstandard2.0
  NuGet.VisualStudio.Implementation.csproj = net472
  NuGet.VisualStudio.Internal.Contracts.csproj = net472
  NuGet.VisualStudio.Interop.csproj = net472
  NuGet.VisualStudio.OnlineEnvironment.Client.csproj = net472
  NuGet.VisualStudio.csproj = net472
  Microsoft.Build.NuGetSdkResolver.csproj = net472;net9.0
  NuGet.Build.Tasks.Console.csproj = net472;net9.0
  NuGet.Build.Tasks.Pack.csproj = net472;netstandard2.0
  NuGet.Build.Tasks.csproj = net472;net9.0
  NuGet.CommandLine.XPlat.csproj = net9.0
  NuGet.Commands.csproj = net472;netstandard2.0;net8.0
  NuGet.Common.csproj = net472;netstandard2.0
  NuGet.Configuration.csproj = net472;netstandard2.0
  NuGet.Credentials.csproj = net472;netstandard2.0;net8.0
  NuGet.DependencyResolver.Core.csproj = net472;netstandard2.0;net8.0
  NuGet.Frameworks.csproj = net472;netstandard2.0
  NuGet.LibraryModel.csproj = net472;netstandard2.0
  NuGet.Localization.csproj = netstandard2.0
  NuGet.PackageManagement.csproj = net472;netstandard2.0
  NuGet.Packaging.csproj = net472;netstandard2.0;net8.0
  NuGet.ProjectModel.csproj = net472;netstandard2.0;net8.0
  NuGet.Protocol.csproj = net472;netstandard2.0;net8.0
  NuGet.Resolver.csproj = net472;netstandard2.0;net8.0
  NuGet.Versioning.csproj = net472;netstandard2.0
  NuGet.Console.TestContract.csproj = net472
  NuGet.OptProf.csproj = net472
  NuGet.PackageManagement.UI.TestContract.csproj = net472
  NuGet.Tests.Apex.Daily.csproj = net472
  NuGet.Tests.Apex.csproj = net472

msbuild .\build\build.proj /t:GetAllTargetFrameworks /v:m /restore:false /p:DotNetBuildSourceOnly="true"

  NuGet.CommandLine.FuncTest.csproj = net472
  NuGet.MSSigning.Extensions.FuncTest.csproj = net472
  NuGet.CommandLine.Test.csproj = net472
  NuGet.Indexing.Test.csproj = net472
  NuGet.MSSigning.Extensions.Test.csproj = net472
  NuGet.PackageManagement.UI.Test.csproj = net472
  NuGet.PackageManagement.VisualStudio.Test.csproj = net472
  NuGet.SolutionRestoreManager.Test.csproj = net472
  NuGet.Tools.Test.csproj = net472
  NuGet.VisualStudio.Common.Test.csproj = net472
  NuGet.VisualStudio.Implementation.Test.csproj = net472
  NuGet.VisualStudio.Internal.Contracts.Test.csproj = net472
  NuGet.VisualStudio.Test.csproj = net472
  NuGetConsole.Host.PowerShell.Test.csproj = net472
  Dotnet.Integration.Test.csproj = net10.0
  Msbuild.Integration.Test.csproj = net472
  NuGet.Commands.FuncTest.csproj = net10.0
  NuGet.Packaging.FuncTest.csproj = net10.0
  NuGet.Protocol.FuncTest.csproj = net10.0
  NuGet.Signing.CrossFramework.Test.csproj = net10.0
  NuGet.XPlat.FuncTest.csproj = net10.0
  Microsoft.Build.NuGetSdkResolver.Test.csproj = net10.0
  NuGet.Build.Tasks.Console.Test.csproj = net10.0
  NuGet.Build.Tasks.Pack.Test.csproj = net10.0
  NuGet.Build.Tasks.Test.csproj = net10.0
  NuGet.CommandLine.Xplat.Tests.csproj = net10.0
  NuGet.Commands.Test.csproj = net10.0
  NuGet.Common.Test.csproj = net10.0
  NuGet.Configuration.Test.csproj = net10.0
  NuGet.Credentials.Test.csproj = net10.0
  NuGet.DependencyResolver.Core.Tests.csproj = net10.0
  NuGet.Frameworks.Test.csproj = net10.0
  NuGet.LibraryModel.Tests.csproj = net10.0
  NuGet.PackageManagement.Test.csproj = net10.0
  NuGet.Packaging.Test.csproj = net10.0
  NuGet.ProjectModel.Test.csproj = net10.0
  NuGet.Protocol.Tests.csproj = net10.0
  NuGet.Resolver.Test.csproj = net10.0
  NuGet.Shared.Tests.csproj = net10.0
  NuGet.Versioning.Test.csproj = net10.0
  API.Test.csproj = net472
  GenerateLicenseList.csproj = net8.0
  GenerateTestPackages.csproj = net472
  SampleCommandLineExtensions.csproj = net472
  TestableCredentialProvider.csproj = net472
  TestablePlugin.csproj = net10.0
  Microsoft.Internal.NuGet.Testing.SignedPackages.csproj = net10.0
  Test.Utility.csproj = net10.0
  NuGet.CommandLine.csproj = net472
  NuGet.Console.csproj = net472
  NuGet.Indexing.csproj = net472
  NuGet.MSSigning.Extensions.csproj = net472
  NuGet.PackageManagement.PowerShellCmdlets.csproj = net472
  NuGet.PackageManagement.UI.csproj = net472
  NuGet.PackageManagement.VisualStudio.csproj = net472
  NuGet.SolutionRestoreManager.csproj = net472
  NuGet.Tools.csproj = net472
  NuGet.VisualStudio.Client.csproj = net472
  NuGet.VisualStudio.Common.csproj = net472
  NuGet.VisualStudio.Contracts.csproj = netstandard2.0
  NuGet.VisualStudio.Implementation.csproj = net472
  NuGet.VisualStudio.Internal.Contracts.csproj = net472
  NuGet.VisualStudio.Interop.csproj = net472
  NuGet.VisualStudio.OnlineEnvironment.Client.csproj = net472
  NuGet.VisualStudio.csproj = net472
  Microsoft.Build.NuGetSdkResolver.csproj = net10.0
  NuGet.Build.Tasks.Console.csproj = net10.0
  NuGet.Build.Tasks.Pack.csproj = net10.0;netstandard2.0
  NuGet.Build.Tasks.csproj = net10.0
  NuGet.CommandLine.XPlat.csproj = net10.0
  NuGet.Commands.csproj = net10.0;netstandard2.0
  NuGet.Common.csproj = net10.0;netstandard2.0
  NuGet.Configuration.csproj = net10.0;netstandard2.0
  NuGet.Credentials.csproj = net10.0;netstandard2.0
  NuGet.DependencyResolver.Core.csproj = net10.0;netstandard2.0
  NuGet.Frameworks.csproj = net10.0;netstandard2.0
  NuGet.LibraryModel.csproj = net10.0;netstandard2.0
  NuGet.Localization.csproj = netstandard2.0
  NuGet.PackageManagement.csproj = net10.0;netstandard2.0
  NuGet.Packaging.csproj = net10.0;netstandard2.0
  NuGet.ProjectModel.csproj = net10.0;netstandard2.0
  NuGet.Protocol.csproj = net10.0;netstandard2.0
  NuGet.Resolver.csproj = net10.0;netstandard2.0
  NuGet.Versioning.csproj = net10.0;netstandard2.0
  NuGet.Console.TestContract.csproj = net472
  NuGet.OptProf.csproj = net472
  NuGet.PackageManagement.UI.TestContract.csproj = net472
  NuGet.Tests.Apex.Daily.csproj = net472
  NuGet.Tests.Apex.csproj = net472

Frameworks after:

msbuild .\build\build.proj /t:GetAllTargetFrameworks /v:m /restore:false

  NuGet.CommandLine.FuncTest.csproj = net472
  NuGet.MSSigning.Extensions.FuncTest.csproj = net472
  NuGet.CommandLine.Test.csproj = net472
  NuGet.Indexing.Test.csproj = net472
  NuGet.MSSigning.Extensions.Test.csproj = net472
  NuGet.PackageManagement.UI.Test.csproj = net472
  NuGet.PackageManagement.VisualStudio.Test.csproj = net472
  NuGet.SolutionRestoreManager.Test.csproj = net472
  NuGet.Tools.Test.csproj = net472
  NuGet.VisualStudio.Common.Test.csproj = net472
  NuGet.VisualStudio.Implementation.Test.csproj = net472
  NuGet.VisualStudio.Internal.Contracts.Test.csproj = net472
  NuGet.VisualStudio.Test.csproj = net472
  NuGetConsole.Host.PowerShell.Test.csproj = net472
  Dotnet.Integration.Test.csproj = net8.0
  Msbuild.Integration.Test.csproj = net472
  NuGet.Commands.FuncTest.csproj = net472;net8.0;netcoreapp3.1
  NuGet.Packaging.FuncTest.csproj = net472;net8.0;netcoreapp3.1
  NuGet.Protocol.FuncTest.csproj = net472;net8.0;netcoreapp3.1
  NuGet.Signing.CrossFramework.Test.csproj = net472;net8.0
  NuGet.XPlat.FuncTest.csproj = net8.0
  Microsoft.Build.NuGetSdkResolver.Test.csproj = net472;net8.0
  NuGet.Build.Tasks.Console.Test.csproj = net472;net8.0
  NuGet.Build.Tasks.Pack.Test.csproj = net472;net8.0
  NuGet.Build.Tasks.Test.csproj = net472;net8.0
  NuGet.CommandLine.Xplat.Tests.csproj = net8.0
  NuGet.Commands.Test.csproj = net472;net8.0;netcoreapp3.1
  NuGet.Common.Test.csproj = net472;net8.0
  NuGet.Configuration.Test.csproj = net472;net8.0;netcoreapp3.1
  NuGet.Credentials.Test.csproj = net472;net8.0
  NuGet.DependencyResolver.Core.Tests.csproj = net472;net8.0;netcoreapp3.1
  NuGet.Frameworks.Test.csproj = net472;net8.0
  NuGet.LibraryModel.Tests.csproj = net472;net8.0
  NuGet.PackageManagement.Test.csproj = net472;net8.0
  NuGet.Packaging.Test.csproj = net472;net8.0;netcoreapp3.1
  NuGet.ProjectModel.Test.csproj = net472;net8.0;netcoreapp3.1
  NuGet.Protocol.Tests.csproj = net472;net8.0;netcoreapp3.1
  NuGet.Resolver.Test.csproj = net472;net8.0;netcoreapp3.1
  NuGet.Shared.Tests.csproj = net472;net8.0
  NuGet.Versioning.Test.csproj = net472;net8.0
  API.Test.csproj = net472
  GenerateLicenseList.csproj = net8.0
  GenerateTestPackages.csproj = net472
  SampleCommandLineExtensions.csproj = net472
  TestableCredentialProvider.csproj = net472
  TestablePlugin.csproj = net472;net8.0;netcoreapp3.1
  Microsoft.Internal.NuGet.Testing.SignedPackages.csproj = net472;net8.0;netcoreapp3.1
  Test.Utility.csproj = net472;net8.0;netcoreapp3.1
  NuGet.CommandLine.csproj = net472
  NuGet.Console.csproj = net472
  NuGet.Indexing.csproj = net472
  NuGet.MSSigning.Extensions.csproj = net472
  NuGet.PackageManagement.PowerShellCmdlets.csproj = net472
  NuGet.PackageManagement.UI.csproj = net472
  NuGet.PackageManagement.VisualStudio.csproj = net472
  NuGet.SolutionRestoreManager.csproj = net472
  NuGet.Tools.csproj = net472
  NuGet.VisualStudio.Client.csproj = net472
  NuGet.VisualStudio.Common.csproj = net472
  NuGet.VisualStudio.Contracts.csproj = netstandard2.0
  NuGet.VisualStudio.Implementation.csproj = net472
  NuGet.VisualStudio.Internal.Contracts.csproj = net472
  NuGet.VisualStudio.Interop.csproj = net472
  NuGet.VisualStudio.OnlineEnvironment.Client.csproj = net472
  NuGet.VisualStudio.csproj = net472
  Microsoft.Build.NuGetSdkResolver.csproj = net472;net8.0
  NuGet.Build.Tasks.Console.csproj = net472;net8.0
  NuGet.Build.Tasks.Pack.csproj = net472;netstandard2.0
  NuGet.Build.Tasks.csproj = net472;net8.0
  NuGet.CommandLine.XPlat.csproj = net8.0
  NuGet.Commands.csproj = net472;netstandard2.0;net8.0
  NuGet.Common.csproj = net472;netstandard2.0
  NuGet.Configuration.csproj = net472;netstandard2.0
  NuGet.Credentials.csproj = net472;netstandard2.0;net8.0
  NuGet.DependencyResolver.Core.csproj = net472;netstandard2.0;net8.0
  NuGet.Frameworks.csproj = net472;netstandard2.0
  NuGet.LibraryModel.csproj = net472;netstandard2.0
  NuGet.Localization.csproj = netstandard2.0
  NuGet.PackageManagement.csproj = net472;netstandard2.0
  NuGet.Packaging.csproj = net472;netstandard2.0;net8.0
  NuGet.ProjectModel.csproj = net472;netstandard2.0;net8.0
  NuGet.Protocol.csproj = net472;netstandard2.0;net8.0
  NuGet.Resolver.csproj = net472;netstandard2.0;net8.0
  NuGet.Versioning.csproj = net472;netstandard2.0
  NuGet.Console.TestContract.csproj = net472
  NuGet.OptProf.csproj = net472
  NuGet.PackageManagement.UI.TestContract.csproj = net472
  NuGet.Tests.Apex.Daily.csproj = net472
  NuGet.Tests.Apex.csproj = net472

msbuild .\build\build.proj /t:GetAllTargetFrameworks /v:m /restore:false /p:DotNetBuildSourceOnly="true"

  NuGet.CommandLine.FuncTest.csproj = net472
  NuGet.MSSigning.Extensions.FuncTest.csproj = net472
  NuGet.CommandLine.Test.csproj = net472
  NuGet.Indexing.Test.csproj = net472
  NuGet.MSSigning.Extensions.Test.csproj = net472
  NuGet.PackageManagement.UI.Test.csproj = net472
  NuGet.PackageManagement.VisualStudio.Test.csproj = net472
  NuGet.SolutionRestoreManager.Test.csproj = net472
  NuGet.Tools.Test.csproj = net472
  NuGet.VisualStudio.Common.Test.csproj = net472
  NuGet.VisualStudio.Implementation.Test.csproj = net472
  NuGet.VisualStudio.Internal.Contracts.Test.csproj = net472
  NuGet.VisualStudio.Test.csproj = net472
  NuGetConsole.Host.PowerShell.Test.csproj = net472
  Dotnet.Integration.Test.csproj = net10.0
  Msbuild.Integration.Test.csproj = net472
  NuGet.Commands.FuncTest.csproj = net10.0
  NuGet.Packaging.FuncTest.csproj = net10.0
  NuGet.Protocol.FuncTest.csproj = net10.0
  NuGet.Signing.CrossFramework.Test.csproj = net10.0
  NuGet.XPlat.FuncTest.csproj = net10.0
  Microsoft.Build.NuGetSdkResolver.Test.csproj = net10.0
  NuGet.Build.Tasks.Console.Test.csproj = net10.0
  NuGet.Build.Tasks.Pack.Test.csproj = net10.0
  NuGet.Build.Tasks.Test.csproj = net10.0
  NuGet.CommandLine.Xplat.Tests.csproj = net10.0
  NuGet.Commands.Test.csproj = net10.0
  NuGet.Common.Test.csproj = net10.0
  NuGet.Configuration.Test.csproj = net10.0
  NuGet.Credentials.Test.csproj = net10.0
  NuGet.DependencyResolver.Core.Tests.csproj = net10.0
  NuGet.Frameworks.Test.csproj = net10.0
  NuGet.LibraryModel.Tests.csproj = net10.0
  NuGet.PackageManagement.Test.csproj = net10.0
  NuGet.Packaging.Test.csproj = net10.0
  NuGet.ProjectModel.Test.csproj = net10.0
  NuGet.Protocol.Tests.csproj = net10.0
  NuGet.Resolver.Test.csproj = net10.0
  NuGet.Shared.Tests.csproj = net10.0
  NuGet.Versioning.Test.csproj = net10.0
  API.Test.csproj = net472
  GenerateLicenseList.csproj = net8.0
  GenerateTestPackages.csproj = net472
  SampleCommandLineExtensions.csproj = net472
  TestableCredentialProvider.csproj = net472
  TestablePlugin.csproj = net10.0
  Microsoft.Internal.NuGet.Testing.SignedPackages.csproj = net10.0
  Test.Utility.csproj = net10.0
  NuGet.CommandLine.csproj = net472
  NuGet.Console.csproj = net472
  NuGet.Indexing.csproj = net472
  NuGet.MSSigning.Extensions.csproj = net472
  NuGet.PackageManagement.PowerShellCmdlets.csproj = net472
  NuGet.PackageManagement.UI.csproj = net472
  NuGet.PackageManagement.VisualStudio.csproj = net472
  NuGet.SolutionRestoreManager.csproj = net472
  NuGet.Tools.csproj = net472
  NuGet.VisualStudio.Client.csproj = net472
  NuGet.VisualStudio.Common.csproj = net472
  NuGet.VisualStudio.Contracts.csproj = netstandard2.0
  NuGet.VisualStudio.Implementation.csproj = net472
  NuGet.VisualStudio.Internal.Contracts.csproj = net472
  NuGet.VisualStudio.Interop.csproj = net472
  NuGet.VisualStudio.OnlineEnvironment.Client.csproj = net472
  NuGet.VisualStudio.csproj = net472
  Microsoft.Build.NuGetSdkResolver.csproj = net10.0
  NuGet.Build.Tasks.Console.csproj = net10.0
  NuGet.Build.Tasks.Pack.csproj = net10.0;netstandard2.0
  NuGet.Build.Tasks.csproj = net10.0
  NuGet.CommandLine.XPlat.csproj = net10.0
  NuGet.Commands.csproj = net10.0;netstandard2.0
  NuGet.Common.csproj = net10.0;netstandard2.0
  NuGet.Configuration.csproj = net10.0;netstandard2.0
  NuGet.Credentials.csproj = net10.0;netstandard2.0
  NuGet.DependencyResolver.Core.csproj = net10.0;netstandard2.0
  NuGet.Frameworks.csproj = net10.0;netstandard2.0
  NuGet.LibraryModel.csproj = net10.0;netstandard2.0
  NuGet.Localization.csproj = netstandard2.0
  NuGet.PackageManagement.csproj = net10.0;netstandard2.0
  NuGet.Packaging.csproj = net10.0;netstandard2.0
  NuGet.ProjectModel.csproj = net10.0;netstandard2.0
  NuGet.Protocol.csproj = net10.0;netstandard2.0
  NuGet.Resolver.csproj = net10.0;netstandard2.0
  NuGet.Versioning.csproj = net10.0;netstandard2.0
  NuGet.Console.TestContract.csproj = net472
  NuGet.OptProf.csproj = net472
  NuGet.PackageManagement.UI.TestContract.csproj = net472
  NuGet.Tests.Apex.Daily.csproj = net472
  NuGet.Tests.Apex.csproj = net472

@nkolev92 nkolev92 added the Engineering Changes related to the build infrastructure of the repo and that do not change product code label Jan 25, 2025
@nkolev92 nkolev92 marked this pull request as ready for review January 25, 2025 02:00
@nkolev92 nkolev92 requested a review from a team as a code owner January 25, 2025 02:00
Nigusu-Allehu
Nigusu-Allehu previously approved these changes Jan 27, 2025
jgonz120
jgonz120 previously approved these changes Jan 27, 2025
@jgonz120 jgonz120 requested a review from martinrrm January 27, 2025 20:23
@jeffkl
Copy link
Contributor

jeffkl commented Jan 27, 2025

You'll need to update this logic in the YAML:

- ${{ if eq(parameters.RunFunctionalTestsOnWindows, true) }}:
- stage:
displayName: Dotnet.Integration.Test on Windows (.NET 8.0)
dependsOn: []
jobs:
- template: pr.job.yml
parameters:
displayName: Dotnet.Integration.Test on Windows (.NET 8.0)
osName: Windows
${{ if eq(variables['System.TeamProject'], 'public') }}:
agentPool: NetCore-Public
agentDemands: ImageOverride -equals Windows.VS2022.Amd64.Open
${{ else }}:
agentPool: VSEngSS-MicroBuild2022-1ES
testType: Functional
testTargetFramework: net8.0
testProjectName: Dotnet.Integration.Test
timeoutInMinutes: 45

I had been working on a way to make this more automatic but its hard and I didn't think we changed frameworks enough to warrant spending more time on it. There's probably more sections to change, let me know if you need help and I can push to your branch.

@nkolev92
Copy link
Member Author

Eventually, we'd want to go back to only a single Core framework anyways, so we can go back to ".NET tests' and ".NET Framework tests".

@nkolev92 nkolev92 dismissed stale reviews from jgonz120 and Nigusu-Allehu via 689e2ac January 28, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Changes related to the build infrastructure of the repo and that do not change product code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants