Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project.json migrator #6242

Merged
merged 5 commits into from
Jan 31, 2025
Merged

Add project.json migrator #6242

merged 5 commits into from
Jan 31, 2025

Conversation

nkolev92
Copy link
Member

@nkolev92 nkolev92 commented Jan 25, 2025

Bug

Related: NuGet/Home#7199
Fixes: https://github.com/NuGet/Client.Engineering/issues/3158

Description

As part of the project.json migration, we need to expose the migrator in the references node of the migrator. This will allow us to prompt migration for customers.

image
Note that the migrator already exists and has been used for UWP project.json migration.

In addition to exposing the migrator, I have also added a migration event that will allow us to track the status of the migration.

https://github.com/NuGet/Client.Engineering/issues/3158

It has the following properties:

Property Description
ProjectId Allows us to correlate to the project information events.
ProjectFullPath Allows us to correlate to the restore events
Status The status of the operation. We're looking for success, we'd dig deeper if we get any failures
Status Performance purposes.
StartTime Performance purposes.
EndTime Performance purposes.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests Unfortunately there's no tests for the context menus. I'll ask the test team to add test cases for this.
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc. - Document the project.json migrator Home#14071

@nkolev92 nkolev92 marked this pull request as ready for review January 29, 2025 01:30
@nkolev92 nkolev92 requested a review from a team as a code owner January 29, 2025 01:30
martinrrm
martinrrm previously approved these changes Jan 29, 2025
Copy link
Contributor

@jgonz120 jgonz120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

src/NuGet.Clients/NuGet.Tools/NuGetPackage.cs Show resolved Hide resolved
@nkolev92 nkolev92 enabled auto-merge (squash) January 31, 2025 00:42
@nkolev92 nkolev92 merged commit c5934bd into dev Jan 31, 2025
20 of 23 checks passed
@nkolev92 nkolev92 deleted the dev-nkolev92-projectJsonMigrator branch January 31, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants