-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project.json migrator #6242
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
reviewed
Jan 29, 2025
martinrrm
previously approved these changes
Jan 29, 2025
jgonz120
reviewed
Jan 29, 2025
427846a
to
db1188a
Compare
jgonz120
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
jeffkl
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Related: NuGet/Home#7199
Fixes: https://github.com/NuGet/Client.Engineering/issues/3158
Description
As part of the project.json migration, we need to expose the migrator in the references node of the migrator. This will allow us to prompt migration for customers.
Note that the migrator already exists and has been used for UWP project.json migration.
In addition to exposing the migrator, I have also added a migration event that will allow us to track the status of the migration.
https://github.com/NuGet/Client.Engineering/issues/3158
It has the following properties:
PR Checklist
Added testsUnfortunately there's no tests for the context menus. I'll ask the test team to add test cases for this.