[FIX] event_sale: failed payment on soldout events #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chienandalu
force-pushed
the
15.0-fix-event_sale-pay-event-with-no-seats
branch
2 times, most recently
from
d1d2a5e to
36081bd
Compare
When there's a quotation for events registrations and the seats are limited, if the customer pays the quoutation the payment will fail when the quoutation gets confirmed. With this change we prevent the customer from paying that event that is soldout. Steps to reproduce: - Limit the seats for a given event. - Set autoconfirmation on. - Create a quotation for a ticket in that event. - Use the customer preview link to go to the portal view. - Pay the quotation (i.e. with demo payment method) - The confirmation crashes as there aren't seats available. This is an issue as well as the payment is already fulfilled at bank level, but as the system crashes the callback isn't confirmed at Odoo.
chienandalu
force-pushed
the
15.0-fix-event_sale-pay-event-with-no-seats
branch
from
36081bd to
862ac93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to backport if odoo#194360 gets merged
When there's a quotation for events registrations and the seats are limited, if the customer pays the quoutation the payment will fail when the quoutation gets confirmed.
With this change we prevent the customer from paying that event that is soldout.
Steps to reproduce:
This is an issue as well as the payment is already fulfilled at bank level, but as the system crashes the callback isn't confirmed at Odoo.
cc @Tecnativa @pedrobaeza TT54556
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr