[18.0][MIG] purchase_analytic: Migration to 18.0 #732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-analytic-12.0/account-analytic-12.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-purchase_analytic/
Some of the "tricks" done in this module are no longer needed and can be easily implemented with newest framework features: * No need for an auxiliar `project_id2` field. User can set an analytic account with no lines and it is respected. * Simplify onchange. Now update analytic line on the go (no need to save) which is a better UX because avoid unexpected changes on save. Also re-label the field `project_id` to "Analytic Account" to align with the typical label in newer versions of Odoo. Tha label "Contract / Analytic" was last used in v8 ( https://github.com/odoo/odoo/blob/8.0/addons/sale/sale.py#L217).
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-analytic-15.0/account-analytic-15.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-15-0/account-analytic-15-0-purchase_analytic/
Currently translated at 100.0% (3 of 3 strings) Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/hr/
Currently translated at 100.0% (3 of 3 strings) Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/es/
Currently translated at 100.0% (3 of 3 strings) Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/fr/
Currently translated at 100.0% (4 of 4 strings) Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/pt_BR/
Currently translated at 100.0% (4 of 4 strings) Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/es/
Co-authored-by: Alexis de Lattre <[email protected]>
Currently translated at 100.0% (4 of 4 strings) Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/
Currently translated at 100.0% (5 of 5 strings) Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/
Currently translated at 100.0% (5 of 5 strings) Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/it/
Currently translated at 100.0% (5 of 5 strings) Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/
Currently translated at 100.0% (7 of 7 strings) Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/it/
Currently translated at 100.0% (7 of 7 strings) Translation: account-analytic-16.0/account-analytic-16.0-purchase_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-purchase_analytic/pt_BR/
kimirondon
force-pushed
the
18.0-mig-purchase_analytic
branch
2 times, most recently
from
732aa3f to
2c379e7
Compare
kimirondon
force-pushed
the
18.0-mig-purchase_analytic
branch
from
2c379e7 to
1c8c97f
Compare
kimirondon
changed the title
|
You're skipping v17 in this PR. When you proposed this PR, the migration of the module for v17 was already underway. You might have based your work on that, and participated in the review. As it is, the migration of v17 is now merged and there is a PR that is based on the v17: #737. I hope you'll understand I'm closing this PR in favor of that one. |
|
hello @StefanRijnhart! I could've just rebase my branch to add v17 migration, but I understand. Thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.