[17.0][MIG] account_chart_update: Migration to 17.0

[victoralmau]

Supersedes #1888

Migration to 17.0

Changes done:

• Purge translations
• Squash administrative commits
• Change name_get to _compute_display_name
• Change attrs to invisible/required
• Adapt to the new account.chart.template system without records
• Remove recreate_xml_ids fields (It is always necessary for them to have the expected xml_id)
• Adapt tests
• Improve similar methods to reduce code

Please @pedrobaeza can you review it?

@Tecnativa TT49275

[giarve]

these 3 diffs always appear on runbot even after applying the wizard twice with the same chart. I do not know if you want to take a look. Everything else works good.

It is true though that not being able to edit the chart template from inside odoo is less convenient (to change the number of padding zeroes for example).

[giarve]

only showing the xml id makes it harder to see new accounts and their name.

However, this is just an improvement so not requesting anything here. Also might be enough in 99% of the cases.

[victoralmau]

these 3 diffs always appear on runbot even after applying the wizard twice with the same chart. I do not know if you want to take a look. Everything else works good.

It is true though that not being able to edit the chart template from inside odoo is less convenient (to change the number of padding zeroes for example).

Thanks, checked and fixed.

[DavidJForgeFlow]

Code LGTM! Seems to be working fine also 👍

[LoisRForgeFlow]

Functional review 👍

[pedrobaeza]

/ocabot migration account_chart_update

[pedrobaeza]

Several things:

• Is there any possibility to only load in the "Chart template" dropdown those that are already installed?
• When a tax group is not present (because for example is added in the last update), you get an error. You can force to happen trying to load Spanish taxes on generic CoA for example.

[victoralmau]

Several things:

* Is there any possibility to only load in the "Chart template" dropdown those that are already installed?

* When a tax group is not present (because for example is added in the last update), you get an error. You can force to happen trying to load Spanish taxes on generic CoA for example.

Changes done. The test error related to _logger I don't understand, any idea?

[victoralmau]

The test error is finally fixed.

[syci]

The wizard does not take into account the selected language.

https://github.com/Tecnativa/account-financial-tools/blob/b20ed9d7be75352d92041b2478c4af557fa769d4/account_chart_update/wizard/wizard_chart_update.py#L767

In a plan update the name of the taxes always appears in English.

With this change it works correctly.

    def _load_data(self, model, data):
        """Process similar to the one in chart template."""
        template = self.env["account.chart.template"].with_context(
            default_company_id=self.company_id.id,
            allowed_company_ids=[self.company_id.id],
            tracking_disable=True,
            delay_account_group_sync=True,
            lang=self.lang,
        )

[victoralmau]

The wizard does not take into account the selected language.

https://github.com/Tecnativa/account-financial-tools/blob/b20ed9d7be75352d92041b2478c4af557fa769d4/account_chart_update/wizard/wizard_chart_update.py#L767

In a plan update the name of the taxes always appears in English.

With this change it works correctly.

    def _load_data(self, model, data):
        """Process similar to the one in chart template."""
        template = self.env["account.chart.template"].with_context(
            default_company_id=self.company_id.id,
            allowed_company_ids=[self.company_id.id],
            tracking_disable=True,
            delay_account_group_sync=True,
            lang=self.lang,
        )

Thanks for the comment, it has been solved so that the language is correctly taken into account (the suggestion you proposed was not enough).

[pedrobaeza]

The language thing is still not working correctly. Do the following:

• On a fresh runboat (current one has been contaminated), load Spanish language, and switch to it.
• Run the chart update with Spanish selected.
• Result: The accounts in Spanish are update to the English names.

[victoralmau]

The language thing is still not working correctly. Do the following:

* On a fresh runboat (current one has been contaminated), load Spanish language, and switch to it.

* Run the chart update with Spanish selected.

* Result: The accounts in Spanish are update to the English names.

Partially solved, this use case only happens when using generic_coa in a language other than English, because the data returned is not always translated, I have tried with for example l10n_es in Spanish and it works correctly (it does not detect any change).

[pedrobaeza]

About the languages, I'm afraid is not working when you change to other language than the original one that was installed:

And another thing. As we have now a place where putting the button:

don't create a separate section, but place it inside, and you can rename the existing one to "Reload for new elements", and the new one to "Update chart of accounts" (they can even be in the same row I think).

[victoralmau]

About the languages, I'm afraid is not working when you change to other language than the original one that was installed:

Sorry, but I think there is an important confusion, when you select a language in the wizard (English) the data is checked in English (even if we are looking at things in Spanish). IMO this is coherent.

[pedrobaeza]

Oh, wait, I was starting from a bad assumption: that the account name is not translatable. But that's not the case anymore in this version. Thus, now I understand what you were saying. In this case, I think we should directly remove the language in the wizard, and check all the languages at the same time, and refresh it if any is changed.

[victoralmau]

don't create a separate section, but place it inside, and you can rename the existing one to "Reload for new elements", and the new one to "Update chart of accounts" (they can even be in the same row I think).

Changes done.

[victoralmau]

Oh, wait, I was starting from a bad assumption: that the account name is not translatable. But that's not the case anymore in this version. Thus, now I understand what you were saying. In this case, I think we should directly remove the language in the wizard, and check all the languages at the same time, and refresh it if any is changed.

Ok, changes done.

[syci]

I have tried the update and the language now works well.

[pedrobaeza]

Thanks for all the changes and congratulations for the final result.

/ocabot merge nobump

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1989-by-pedrobaeza-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 1dbbf2a. Thanks a lot for contributing to OCA. ❤️