[14.0][FIX] account_invoice_triple_discount: recomputed taxes overwritten by old move line values #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y old move line values We only need to save and restore the invoice lines, not all the move lines as is currently happening. The restoration of the old lines is overwriting the changes made in the tax lines by the tax recomputation in line https://github.com/OCA/account-invoicing/blob/9b64ecc2b8e9b5146a12994b5c13f9a603b0db17/account_invoice_triple_discount/models/account_move.py#L30
rafaelbn
changed the title
|
If all of you, in this great OCA maka a cross review of the same module! I'm sure the force will be with us and you can fix all BUGs in all versions @eantones @ao-landoo @Segui-S79 @odooNextev @ramiadavid
❤️ OCA ❤️ |
eantones
changed the title
|
Fixed in #1605 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only need to save and restore the invoice lines, not all the move lines as is currently happening.
The restoration of the old lines is overwriting the changes made in the tax lines by the tax recomputation in line
account-invoicing/account_invoice_triple_discount/models/account_move.py
Line 30 in 9b64ecc
This is a problem in a certain situations like in repair_discount module where the old values are kept due to this bug.
https://github.com/OCA/manufacture/blob/035a4de34a0de7e4f0db1a9c0ab3354acf235e99/repair_discount/models/mrp_repair.py#L115-L119