Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] stock_picking_return_refund_option: Migration to 18.0 #1931

Merged

Conversation

CarlosRoca13
Copy link

sergio-teruel and others added 18 commits February 28, 2025 13:31
…ntities when user check to refund in operation lines.
We force the delivery creating stock.move.line for avoiding
circumstances where the assignation is not done.

The SO creation is also simplified using Form utility, and now as we
don't depend on the warehouse, we remove such code as well.
There's still some cases that makes the pickings to not be completed, so
we force them and also switch to Form for simplifying code.
[UPD] Update stock_picking_return_refund_option.pot

[UPD] README.rst

Added translation using Weblate (Catalan)

Translated using Weblate (Catalan)

Currently translated at 42.8% (3 of 7 strings)

Translation: account-invoicing-15.0/account-invoicing-15.0-stock_picking_return_refund_option
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-stock_picking_return_refund_option/ca/
Change reference from move_lines to move_ids
The field move_lines in Odoo 15 change to move_ids in Odoo 16

fix mig - 16
- Include context keys for avoiding mail operations overhead.
Since odoo/odoo@d0342c8, the default existing company is not getting a
CoA automatically, provoking than the current tests fail with the error:

odoo.exceptions.UserError: No journal could be found in company My Company (San Francisco) for any of those types: sale

Thus, we put tests post-install for being sure localization modules are
installed, the same as AccountTestInvoicingCommon does, but we don't
inherit from it, as it creates an overhead creating 2 new companies and
loading their CoA and some more stuff, while we don't need all of that.

Besides, if you don't have `l10n_generic_coa` installed, you can't use
another CoA (like `l10n_es`) easily, so we put little code to select the
first available CoA.
@CarlosRoca13 CarlosRoca13 force-pushed the 18.0-MIG-stock_picking_return_refund_option branch from d0927a5 to 24846d6 Compare February 28, 2025 14:51
@pedrobaeza
Copy link
Member

/ocabot migration stock_picking_return_refund_option

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Feb 28, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 28, 2025
17 tasks
Copy link
Contributor

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test OK...

Copy link

@carlosdauden carlosdauden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are loops necessary?

@CarlosRoca13 CarlosRoca13 force-pushed the 18.0-MIG-stock_picking_return_refund_option branch from 24846d6 to 9eedb1f Compare March 3, 2025 09:35
@CarlosRoca13
Copy link
Author

Are loops necessary?

Loops removed, thanks 😄

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-1931-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 74e9e1f into OCA:18.0 Mar 3, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1ecb34f. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 18.0-MIG-stock_picking_return_refund_option branch March 3, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.