-
-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] stock_picking_return_refund_option: Migration to 18.0 #1931
[18.0][MIG] stock_picking_return_refund_option: Migration to 18.0 #1931
Conversation
…fund options in picking directly
…ntities when user check to refund in operation lines.
…crash test due to this Odoo commit OCA/OCB@8ca10a8
We force the delivery creating stock.move.line for avoiding circumstances where the assignation is not done. The SO creation is also simplified using Form utility, and now as we don't depend on the warehouse, we remove such code as well.
There's still some cases that makes the pickings to not be completed, so we force them and also switch to Form for simplifying code.
[UPD] Update stock_picking_return_refund_option.pot [UPD] README.rst Added translation using Weblate (Catalan) Translated using Weblate (Catalan) Currently translated at 42.8% (3 of 7 strings) Translation: account-invoicing-15.0/account-invoicing-15.0-stock_picking_return_refund_option Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-stock_picking_return_refund_option/ca/
Change reference from move_lines to move_ids The field move_lines in Odoo 15 change to move_ids in Odoo 16 fix mig - 16
- Include context keys for avoiding mail operations overhead.
Since odoo/odoo@d0342c8, the default existing company is not getting a CoA automatically, provoking than the current tests fail with the error: odoo.exceptions.UserError: No journal could be found in company My Company (San Francisco) for any of those types: sale Thus, we put tests post-install for being sure localization modules are installed, the same as AccountTestInvoicingCommon does, but we don't inherit from it, as it creates an overhead creating 2 new companies and loading their CoA and some more stuff, while we don't need all of that. Besides, if you don't have `l10n_generic_coa` installed, you can't use another CoA (like `l10n_es`) easily, so we put little code to select the first available CoA.
d0927a5
to
24846d6
Compare
/ocabot migration stock_picking_return_refund_option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional test OK...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are loops necessary?
24846d6
to
9eedb1f
Compare
Loops removed, thanks 😄 |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 1ecb34f. Thanks a lot for contributing to OCA. ❤️ |
cc @Tecnativa TT54345
ping @sergio-teruel @carlosdauden