Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] account_reconcile: ux improvements #763

Merged
merged 2 commits into from
Dec 12, 2024
Merged

[16.0][IMP] account_reconcile: ux improvements #763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a66dd61
[IMP] account_reconcile_oca: Open reconcile view when press the name …
etobella Oct 16, 2024
e198c74
[IMP] account_statement_base: add group by date
chienandalu Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions account_reconcile_oca/models/account_journal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,12 @@
if self.get_journal_dashboard_datas()["number_to_reconcile"] > 0:
return False
return _("Well done! Everything has been reconciled")

def open_action(self):
self.ensure_one()

Check warning on line 36 in account_reconcile_oca/models/account_journal.py

View check run for this annotation

Codecov / codecov/patch

account_reconcile_oca/models/account_journal.py#L36 

Added line #L36 was not covered by tests
if self.type not in ["bank", "cash"]:
return super().open_action()
action = self.env["ir.actions.actions"]._for_xml_id(

Check warning on line 39 in account_reconcile_oca/models/account_journal.py

View check run for this annotation

Codecov / codecov/patch

account_reconcile_oca/models/account_journal.py#L38-L39 

Added lines #L38 - L39 were not covered by tests
"account_reconcile_oca.action_bank_statement_line_reconcile_all"
)
return action

Check warning on line 42 in account_reconcile_oca/models/account_journal.py

View check run for this annotation

Codecov / codecov/patch

account_reconcile_oca/models/account_journal.py#L42 

Added line #L42 was not covered by tests
6 changes: 3 additions & 3 deletions account_reconcile_oca/views/account_bank_statement_line.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,12 +356,12 @@
<field
name="context"
>{'default_journal_id': active_id, 'view_ref': 'account_reconcile_oca.bank_statement_line_form_reconcile_view'}</field>
<field name="view_mode">tree,kanban</field>
<field name="view_mode">kanban,tree</field>
<field
name="view_ids"
eval="[(5, 0, 0),
(0, 0, {'view_mode': 'tree', 'view_id': ref('account_statement_base.account_bank_statement_line_tree')}),
(0, 0, {'view_mode': 'kanban', 'view_id': ref('bank_statement_line_reconcile_view')})]"
(0, 0, {'view_mode': 'kanban', 'view_id': ref('bank_statement_line_reconcile_view')}),
(0, 0, {'view_mode': 'tree', 'view_id': ref('account_statement_base.account_bank_statement_line_tree')})]"
/>
<field name="help" type="html">
<p class="o_view_nocontent_smiling_face">
Expand Down
5 changes: 5 additions & 0 deletions account_statement_base/views/account_bank_statement_line.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,11 @@
string="Transaction Type"
context="{'group_by': 'transaction_type'}"
/>
<filter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<filter
<filter

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well this is indeed aligned with the above tags formatting... I didn't want to reformat so much to avoid the noise

name="date_groupby"
string="Date"
context="{'group_by': 'date'}"
/>
</group>
</search>
</field>
Expand Down
Loading