Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] sale_commission_product_criteria_discount #466

Merged
merged 7 commits into from
Jun 6, 2024
Merged

[16.0][MIG] sale_commission_product_criteria_discount #466

merged 7 commits into from
Jun 6, 2024

Conversation

SirAionTech
Copy link

@SirAionTech SirAionTech commented Oct 19, 2023 •
edited
Loading

@SirAionTech SirAionTech mentioned this pull request Oct 19, 2023
Merged
1 task
@SirAionTech SirAionTech marked this pull request as ready for review October 19, 2023 08:30
@SirAionTech
Copy link
Author

@ilyasProgrammer, @francesco-ooops you worked on this, maybe you want to have a look?

ilyasProgrammer
ilyasProgrammer approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@ilyasProgrammer ilyasProgrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 18, 2024
@SirAionTech SirAionTech force-pushed the 16.0-mig-sale_commission_product_criteria_discount branch from c7b339e to 0ae4a5d Compare February 19, 2024 08:54
@SirAionTech
Copy link
Author

Rebased after #465 (comment)

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 25, 2024
@SirAionTech SirAionTech force-pushed the 16.0-mig-sale_commission_product_criteria_discount branch from 0ae4a5d to a6bb3c2 Compare March 29, 2024 14:57
francesco-ooops
francesco-ooops approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@SirAionTech SirAionTech mentioned this pull request Apr 4, 2024
Open
1 task
@SirAionTech SirAionTech force-pushed the 16.0-mig-sale_commission_product_criteria_discount branch from a6bb3c2 to e470878 Compare April 4, 2024 08:21
@SirAionTech
Copy link
Author

Rebased on 16.0.

@SirAionTech SirAionTech force-pushed the 16.0-mig-sale_commission_product_criteria_discount branch from e470878 to d57d02a Compare June 6, 2024 07:38
@SirAionTech
Copy link
Author

Rebased on 16.0.

@SirAionTech
Copy link
Author

@ilyasProgrammer you are the maintainer of this module, can you merge?

@francesco-ooops
Copy link
Contributor

@pedrobaeza good to go?

@pedrobaeza pedrobaeza changed the title [MIG] sale_commission_product_criteria_discount [16.0][MIG] sale_commission_product_criteria_discount Jun 6, 2024
@pedrobaeza
Copy link
Member

/ocabot migration sale_commission_product_criteria_discount

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 6, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 6, 2024
Open
12 tasks
@pedrobaeza
Copy link
Member

Merging blindly following current reviews:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-466-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5b1a4fc into OCA:16.0 Jun 6, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0d00e48. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyasProgrammer ilyasProgrammer ilyasProgrammer approved these changes

@francesco-ooops francesco-ooops francesco-ooops approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@SirAionTech @OCA-git-bot @francesco-ooops @pedrobaeza @ilyasProgrammer