[15.0][FIX]account_commission: Settlement on reversed moves #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pedrobaeza, |
Tisho99
force-pushed
the
15.0-fix-account_commission-reversed_moves
branch
3 times, most recently
from
d5b292f to
3409822
Compare
|
The PR is ready @HaraldPanten @ValentinVinagre |
ValentinVinagre
suggested changes
Feb 20, 2024
Tisho99
force-pushed
the
15.0-fix-account_commission-reversed_moves
branch
from
3409822 to
bb2c23a
Compare
|
@HaraldPanten @Jesarregui , could you review it please? |
|
@pedrobaeza do you see it correct? |
pedrobaeza
reviewed
Feb 23, 2024
|
This PR has the |
Tisho99
force-pushed
the
15.0-fix-account_commission-reversed_moves
branch
from
bb2c23a to
305051e
Compare
|
/ocabot merge patch Please forward-port it to v16 |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at e0f7dfe. Thanks a lot for contributing to OCA. ❤️ |
ValentinVinagre
deleted the
15.0-fix-account_commission-reversed_moves
branch
|
@Tisho99 Can you also make the change in v.16? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an error on a use case generating the settlements for the commission on invoices. Steps to reproduce
1 Set up a commission with Invoice State based on paids
2 Create an invoice, confirm it, and asociate his lines to an agent.
3 Generate a credit note to make a full refund of the previous invoice.
4 Settle the commissions for the selected agent. The reversed invoice is not settled and it musts.
The addition of a unit test is pending