Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve migration 16.0 l10n eu nace #195

Conversation

aronabencherif
Copy link

This is an improvement on the migration of thel10n_eu_nacemodule to version 16, taking into account feedback received on this PR #176

Numerigraphe - Lionel Sausin and others added 30 commits October 28, 2023 12:01
Short category names are now displayed on partner views, since NACE names are so long
Data files were there, but translations were not.
[12.0][IMP] - Add unit tests

[IMP] - code improve

Co-authored-by: Jairo Llopis <Yajo@users.noreply.github.com>

Update l10n_eu_nace/migrations/12.0.2.0.0/pre-migration.py

Co-authored-by: Jairo Llopis <Yajo@users.noreply.github.com>

Update l10n_eu_nace/migrations/12.0.2.0.0/post-migration.py

Co-authored-by: Jairo Llopis <Yajo@users.noreply.github.com>

Update l10n_eu_nace/models/res_partner_nace.py

Co-authored-by: Jairo Llopis <Yajo@users.noreply.github.com>

Update l10n_eu_nace/models/res_partner_nace.py

Co-authored-by: Jairo Llopis <Yajo@users.noreply.github.com>

Update l10n_eu_nace/models/res_partner_nace.py

Co-authored-by: Jairo Llopis <Yajo@users.noreply.github.com>

Update l10n_eu_nace/models/res_partner_nace.py

Co-authored-by: Jairo Llopis <Yajo@users.noreply.github.com>

Update l10n_eu_nace/models/res_partner.py

Co-authored-by: Jairo Llopis <Yajo@users.noreply.github.com>

Update l10n_eu_nace/models/res_partner_nace.py

Co-authored-by: Jairo Llopis <Yajo@users.noreply.github.com>

Update l10n_eu_nace/views/res_partner.xml

Co-authored-by: Jairo Llopis <Yajo@users.noreply.github.com>

Update l10n_eu_nace/readme/CONTRIBUTORS.rst

Co-authored-by: Jairo Llopis <Yajo@users.noreply.github.com>

Update l10n_eu_nace/models/res_partner_nace.py

Co-authored-by: Jairo Llopis <Yajo@users.noreply.github.com>

Update l10n_eu_nace/models/res_partner_nace.py

Co-authored-by: Jairo Llopis <Yajo@users.noreply.github.com>

[FIX] - fix code

Update l10n_eu_nace/models/res_partner_nace.py

Co-authored-by: Jairo Llopis <Yajo@users.noreply.github.com>

[FIX] - Fix name_search
Fix post-migration

Co-authored-by: Jairo Llopis <Yajo@users.noreply.github.com>

Update l10n_eu_nace/models/res_partner_nace.py

Co-authored-by: Jairo Llopis <Yajo@users.noreply.github.com>

Update l10n_eu_nace/models/res_partner_nace.py

Co-authored-by: Jairo Llopis <Yajo@users.noreply.github.com>
Some need to add secondary NACE codes to partners.

This is a very little addition, possibly quite standard, so it's done directly in the base addon.

@Tecnativa TT17678
FIX + IMP : more readable query for updating partners with new xml_id regarding old xml_id
@aronabencherif aronabencherif force-pushed the improve_migration_16.0-l10n_eu_nace branch from f73a38b to 21b8500 Compare April 5, 2024 18:04
@edlopen
Copy link
Member

edlopen commented Apr 15, 2024

Hello @aronabencherif ,
it seems that both of us worked on the same module. Here is my PR and it uses the new ShowVoc endoint as RAMON is no longer updated. Also I ditched the res.partner.nace model because is not necessary having the res.partner.industry from Odoo as @yajo said.

I would like to ask if you could have a look to the PR as is my intention to migrate and update other modules that relays on this new dataset cataloge (ShowVoc).

Thank you in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet