Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0][MIG] connector_magento: rename columns #318

Open
wants to merge 2 commits into
base: 10.0
Choose a base branch
from
Open

[10.0][MIG] connector_magento: rename columns #318

wants to merge 2 commits into from

Conversation

StefanRijnhart
Copy link
Member

No description provided.

@StefanRijnhart StefanRijnhart added this to the 10.0 milestone Apr 8, 2021
hbrunn
hbrunn approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what you do in the body of the loop would be a nice addition to rename_colums with some parameter ignore_missing or similar, but that's out of scope here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbrunn hbrunn hbrunn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanRijnhart @hbrunn