Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][PORT] edi_oca: Port edi_oca from edi/14.0 #62

Closed
wants to merge 25 commits into from

Conversation

petrus-v and others added 14 commits January 22, 2024 09:51
Avoid warning because of duplicated Model field name while installing this module
This reverts commit a5da7ac9a3ca1bdc82f8f8ed2e8afc23592fb286.
Archived rules were not visible on the exc type form.
You can now toggle archived/unarchived directly from exc type form
Send jobs might fail due to an external service being not responsive.
If the job is simply failed, a new one will be spawned and might encour in the same error again,
possibly leading to an high number of duplicated jobs for the same record.

Yet, when a RetryableJobError is raised, the job will be set back into pending state
and will be nicely retried based on jobs configuration.
When actions are automated, is nice to see that data has been generated for an exchange on the related record.
@QuocDuong1306 QuocDuong1306 marked this pull request as draft January 22, 2024 03:51
@OCA-git-bot
Copy link
Contributor

Hi @etobella, @simahawk,
some modules you are maintaining are being modified, check this out!

@simahawk
Copy link
Contributor

The change to edi_exchange_template should be excluded.
Can you also update the blacklist file at the end? https://github.com/OCA/edi-framework/blob/16.0/.oca/oca-port/blacklist/edi_oca.json

simahawk and others added 9 commits January 22, 2024 15:15
The recommended way to execute actions on records
is to call `action_exchange_*` on
Instead of waiting for the cron to pass again and send the file
chain the 2 jobs so that it gets sent right after generation.
* catch OSError
* add debug log
Prevents having duplicated jobs for the same record as far as possible.
Try to send out the file as fast as possible once the content is ready.
The origin record should never been copied.
Its values should always be set specifically by a framework action.
@QuocDuong1306
Copy link
Contributor Author

QuocDuong1306 commented Jan 23, 2024

Hello @simahawk , I created PR #63 on top of this one to include the forward-ports for edi_exchange_template_oca as well

@nilshamerlinck
Copy link
Contributor

This PR can be ignored in favor of #63

@simahawk simahawk closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants