-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][PORT] edi_oca: Port edi_oca from edi/14.0 #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid warning because of duplicated Model field name while installing this module
This reverts commit a5da7ac9a3ca1bdc82f8f8ed2e8afc23592fb286.
Archived rules were not visible on the exc type form.
You can now toggle archived/unarchived directly from exc type form
Send jobs might fail due to an external service being not responsive. If the job is simply failed, a new one will be spawned and might encour in the same error again, possibly leading to an high number of duplicated jobs for the same record. Yet, when a RetryableJobError is raised, the job will be set back into pending state and will be nicely retried based on jobs configuration.
When actions are automated, is nice to see that data has been generated for an exchange on the related record.
The change to |
The recommended way to execute actions on records is to call `action_exchange_*` on
Instead of waiting for the cron to pass again and send the file chain the 2 jobs so that it gets sent right after generation.
* catch OSError * add debug log
Prevents having duplicated jobs for the same record as far as possible.
Try to send out the file as fast as possible once the content is ready.
The origin record should never been copied. Its values should always be set specifically by a framework action.
93bcb4a
to
7121976
Compare
d40bde9
to
5c21a9a
Compare
5c21a9a
to
732f2bc
Compare
This PR can be ignored in favor of #63 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port from PRs:
Model
field name edi#808