Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] fleet_vehicle_usage: Migration to 17.0 #161

Closed
wants to merge 5 commits into from

Conversation

elheit
Copy link

@elheit elheit commented Nov 3, 2024

No description provided.

@ivantodorovich
Copy link

Hello!

Thanks for the contribution!

Could you please check the commit history on this PR, it doesn't look right.
There are commits/changes involving other modules than fleet_vehicle_usage

@elheit
Copy link
Author

elheit commented Nov 4, 2024

Hello,
at first i want to migrate just the fleet_vehicle_usage module after that i see the issue target modules list so i want to migrate them all
so should create a request for each module or just rename this request

@marcelsavegnago
Copy link
Member

marcelsavegnago commented Nov 4, 2024

@elheit

Take a look https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

One module per PR please.

Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elheit
Copy link
Author

elheit commented Nov 5, 2024

now it is just one module

@pedrobaeza
Copy link
Member

Thanks for the contribution.

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0.

If the jump is between several versions, you have to modify the source branch in the main command to accommodate it to this circumstance.

@elheit
Copy link
Author

elheit commented Nov 5, 2024

Hello,
Yes I have done it this way

@pedrobaeza
Copy link
Member

I'm afraid not. You haven't respected the previous commit history of the previous contributors of the module. Read my previous message.

@elheit
Copy link
Author

elheit commented Nov 6, 2024

i have check again and the commit history is from the last commit in the branch 17.0
can you explain to me in more detail what exectly the problem

@pedrobaeza
Copy link
Member

You haven't preserved all the commit history, which is https://github.com/OCA/fleet/commits/16.0/fleet_vehicle_usage

@victoralmau
Copy link
Member

Superseded by #166

@pedrobaeza pedrobaeza closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants