Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] document page: Migration to 16.0 #381

Closed
wants to merge 74 commits into from

Conversation

FernandoRomera
Copy link
Contributor

No description provided.

Maxime Chambreuil and others added 30 commits December 5, 2022 13:59
* Add dependency to knowledge
* Adding hack in document_page_history to allow calling method that don't exists
* document_page_history don't have _sql attribute
* Filter more fields
* Changed history widget to html.
* Improved views and added followers to pages.
* Updated document_page pot and es translations.
* document_page:^Cissing dependency.
* [MIG] Migration to version 10.0
* [FIX] Comments and CI errors
* [FIX] ValueError: External ID not found in the system: base.menu_base_partner
* [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview'
* [FIX] Based on @lasley comments
* [FIX] External ID not found in the system: base.group_document_user
Currently translated at 51.9% (28 of 54 strings)

Translation: knowledge-11.0/knowledge-11.0-document_page
Translate-URL: https://translation.odoo-community.org/projects/knowledge-11-0/knowledge-11-0-document_page/fa/
Currently translated at 77.8% (42 of 54 strings)

Translation: knowledge-11.0/knowledge-11.0-document_page
Translate-URL: https://translation.odoo-community.org/projects/knowledge-11-0/knowledge-11-0-document_page/de/
Fixing `Page` parents.
…Add history name field, to name revisions. Modified views to allow setting this field.

[document_page] FIX BUG: UI hanging when editing content. This was due to the api.depends on _compute_diff. Removing it because it's not really necessary since the field is not stored.

[document_page] page_id should be readonly.

Improve active field

[document_page] Update version number

[UPD] Update document_page.pot

[MIG] document_page_multi_company (OCA#188)

* [MIG] document_page_multi_company

Added this feature from the old module directly in document_page
- fix references: report module is now web module

- display_* fields are removed in this version
 * move menus to a higher level.
 * fix categories search view.
 * fix create menu action not being accessible in any way.
 * reorder form view, focusing in the content, not in secondary fields.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: knowledge-12.0/knowledge-12.0-document_page
Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-document_page/
[UPD] README.rst

document_page 12.0.1.1.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: knowledge-12.0/knowledge-12.0-document_page
Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-document_page/

[UPD] README.rst
@FernandoRomera
Copy link
Contributor Author

@pedrobaeza
Thanks.

@rousseldenis
Copy link

@FernandoRomera @pedrobaeza But why having removed the pot file ?

@pedrobaeza
Copy link
Member

It was an attempt to detect the problem, but that's not the question, as both the previous attempts and the one without the POT are in a loop. I have deleted several times the branches, but they get recreated again, so it's the OCA bot that keeps pushing them in a loop. That's why I'm asking to at least recreates them. That may be also the problem for the runboat, creating infinite instances (although not sure if one is created for that temp branch - for me they shouldn't, as they don't bring any value -).

@OCA-git-bot
Copy link
Contributor

@etobella your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-381-by-etobella-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@OCA-git-bot
Copy link
Contributor

@max3903 your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-381-by-max3903-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-381-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@etobella
Copy link
Member

etobella commented Dec 7, 2022

I think it has stopped right now

@pedrobaeza
Copy link
Member

Yeah, it seems so. Let's see if it's due to any manual action by a yet anonymous hero, hehe.

@etobella
Copy link
Member

etobella commented Dec 7, 2022

Well, I started cancelling all the actions and then bot said something failed.... 🤔

@pedrobaeza
Copy link
Member

Let's try again:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-381-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 7, 2022
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-381-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@etobella
Copy link
Member

etobella commented Dec 7, 2022

The error happened again 🤔 It might be a problem of some sort because ot the translation changes 🤔

@FernandoRomera
Copy link
Contributor Author

FernandoRomera commented Dec 7, 2022

@etobella
Do you want me to delete all pot and po files, for testing purposes?

@etobella
Copy link
Member

etobella commented Dec 7, 2022

I think it is fixed with the last commit from #382

Can you take it here and test it 😄

I was able to reproduce it locally. The problem was related to the en.pot file. That was giving problems. Deleting it fixed it all 😄

@pedrobaeza
Copy link
Member

Ouch, how it appeared? That was an old task that removes such file, as indeed it's conflicting.

@etobella
Copy link
Member

etobella commented Dec 7, 2022

It was introduced on 11.0. I don't know why it didn't fail before

MallorcaSoft@125f97d#diff-7002718290bb8efb1df8d91551c698f30f23b4fccb0266ef5352073eb3471f07

@FernandoRomera
Copy link
Contributor Author

@etobella @pedrobaeza
Thank you all for the effort, when you think it is appropriate we could merge this PR.

@pedrobaeza
Copy link
Member

Replaced by #382 for fixing the problem with en.po.

@pedrobaeza pedrobaeza closed this Dec 7, 2022
@etobella
Copy link
Member

etobella commented Dec 7, 2022

Add the commit please and then we can try

@pedrobaeza
Copy link
Member

I have already merged your PR, Enric. As it contains this whole story, there's no attribution problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.